Skip to content

fix(sdk): extend captcha solve request timeout #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leo-notte wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(sdk): extend captcha solve request timeout #913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/notte-sdk/src/notte_sdk/endpoints/page.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
if TYPE_CHECKING:
from notte_sdk.client import NotteClient

CAPTCHA_SOLVE_REQUEST_TIMEOUT_SECONDS = 150


@final
class PageClient(BaseClient):
Expand Down Expand Up @@ -290,7 +292,7 @@ def execute(self, session_id: str, action: ActionUnion) -> ExecutionResultRespon
"""
endpoint = PageClient._page_execute_endpoint(session_id=session_id)
is_captcha = isinstance(action, CaptchaSolveAction)
request_timeout = 100 if is_captcha else self.DEFAULT_REQUEST_TIMEOUT_SECONDS
request_timeout = CAPTCHA_SOLVE_REQUEST_TIMEOUT_SECONDS if is_captcha else self.DEFAULT_REQUEST_TIMEOUT_SECONDS

for _ in range(3):
try:
Expand Down
14 changes: 14 additions & 0 deletions tests/sdk/test_page_execute_timeout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
from unittest.mock import MagicMock

from notte_core.actions import CaptchaSolveAction
from notte_sdk.endpoints.page import CAPTCHA_SOLVE_REQUEST_TIMEOUT_SECONDS, PageClient


def test_captcha_solve_uses_150_second_request_timeout() -> None:
client = PageClient.__new__(PageClient)
client.request = MagicMock(return_value=MagicMock())

client.execute("session-id", CaptchaSolveAction(captcha_type="recaptcha"))

assert CAPTCHA_SOLVE_REQUEST_TIMEOUT_SECONDS == 150
assert client.request.call_args.kwargs["timeout"] == CAPTCHA_SOLVE_REQUEST_TIMEOUT_SECONDS
Loading