fix(sdk): extend captcha solve request timeout - #913
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughAdded the public Estimated code review effort: 2 (Simple) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized change extends only the captcha solve request timeout and preserves other page-action timeouts; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| Filename | Overview |
|---|---|
| packages/notte-sdk/src/notte_sdk/endpoints/page.py | Correctly applies the new 150-second timeout only to captcha-solve actions without changing other page-action timeouts. |
| tests/sdk/test_page_execute_timeout.py | Verifies timeout selection through a mock, but does not provide the integration coverage required for backend bug fixes. |
Reviews (1): Last reviewed commit: "fix(sdk): extend captcha solve request t..." | Re-trigger Greptile
|
Found 1 test failure on Blacksmith runners: Failure
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light.png)
Summary
Companion to nottelabs/monorepo#2345, where captcha polling is 120s, the worker request budget is 130s, and the gateway read budget is 140s.
Test plan
PYTHONPATH=packages/notte-sdk/src:packages/notte-core/src pytest tests/sdk/test_page_execute_timeout.py -qNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit
Bug Fixes
Tests