Skip to content

fix(sdk): extend captcha solve request timeout - #913

Open
leo-notte wants to merge 1 commit into
mainfrom
fix/captcha-request-timeout-150s
Open

fix(sdk): extend captcha solve request timeout#913
leo-notte wants to merge 1 commit into
mainfrom
fix/captcha-request-timeout-150s

Conversation

@leo-notte

@leo-notte leo-notte commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • raise the SDK HTTP timeout for captcha solve requests from 100s to 150s
  • leave the default timeout for other page actions unchanged
  • add focused coverage for the captcha request budget

Companion to nottelabs/monorepo#2345, where captcha polling is 120s, the worker request budget is 130s, and the gateway read budget is 140s.

Test plan

  • PYTHONPATH=packages/notte-sdk/src:packages/notte-core/src pytest tests/sdk/test_page_execute_timeout.py -q

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Bug Fixes

    • CAPTCHA-solving requests now have up to 150 seconds to complete, improving reliability for longer-running challenges.
    • Other page execution requests retain their existing timeout behavior.
  • Tests

    • Added coverage to verify the extended CAPTCHA request timeout.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2d120c23-526f-45b9-9f0d-f4de5c502ac7

📥 Commits

Reviewing files that changed from the base of the PR and between 1802f00 and 84df6b7.

📒 Files selected for processing (2)
  • packages/notte-sdk/src/notte_sdk/endpoints/page.py
  • tests/sdk/test_page_execute_timeout.py

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


Walkthrough

Added the public CAPTCHA_SOLVE_REQUEST_TIMEOUT_SECONDS constant with a value of 150 seconds. PageClient.execute uses this timeout for CaptchaSolveAction requests. Other requests keep the default timeout. Added a unit test that verifies the constant and request timeout.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 84df6

This localized change extends only the captcha solve request timeout and preserves other page-action timeouts; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: increasing the CAPTCHA solve request timeout in the SDK.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/captcha-request-timeout-150s

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Aug 26, 2026

Copy link
Copy Markdown

Greptile Summary

The PR raises the SDK timeout for captcha-solve requests from 100 to 150 seconds while retaining the default timeout for other page actions.

  • Introduces a named captcha request-timeout constant.
  • Selects the extended timeout only for CaptchaSolveAction.
  • Adds focused mocked coverage for timeout selection.

Confidence Score: 4/5

The implementation appears safe to merge, but the repository-required integration coverage should be added.

The timeout selection is correctly limited to captcha actions; the only accepted concern is that the real transport and retry behavior remain uncovered by an integration test.

Files Needing Attention: tests/sdk/test_page_execute_timeout.py

Important Files Changed

Filename Overview
packages/notte-sdk/src/notte_sdk/endpoints/page.py Correctly applies the new 150-second timeout only to captcha-solve actions without changing other page-action timeouts.
tests/sdk/test_page_execute_timeout.py Verifies timeout selection through a mock, but does not provide the integration coverage required for backend bug fixes.

Fix all with Greploop Fix All in Codex

Reviews (1): Last reviewed commit: "fix(sdk): extend captcha solve request t..." | Re-trigger Greptile

@github-actions

Copy link
Copy Markdown
Contributor

Coverage

Tests Skipped Failures Errors Time
915 32 💤 1 ❌ 0 🔥 9m 17s ⏱️

@blacksmith-sh

blacksmith-sh Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
pytest/test_signup_email_extraction View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant