Skip to content

feat(UI): Updated settings dialog UI #10031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Rello wants to merge 9 commits into
base: master
Choose a base branch
from

fix: spacing of Account URL

300fee7
Select commit
Loading
Failed to load commit list.
Draft

feat(UI): Updated settings dialog UI #10031

fix: spacing of Account URL
300fee7
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 15, 2026 in 31m 18s

Quality Gate failed

Failed conditions
6.1% Coverage on New Code (required ≥ 80%)
159 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 70 in src/gui/accountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this macro by "const", "constexpr" or an "enum". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4mqr7A-Svkp3hBDNHO&open=AZ4mqr7A-Svkp3hBDNHO&pullRequest=10031

Check warning on line 123 in src/gui/accountsettings.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4mqr0c-Svkp3hBDNHM&open=AZ4mqr0c-Svkp3hBDNHM&pullRequest=10031

Check warning on line 412 in src/gui/advancedsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the redundant return type of this lambda. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4mqrok-Svkp3hBDNGN&open=AZ4mqrok-Svkp3hBDNGN&pullRequest=10031

Check warning on line 4 in src/gui/settingspanelstyle.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4raYCFhzFqlqqr8wOi&open=AZ4raYCFhzFqlqqr8wOi&pullRequest=10031

Check warning on line 4 in src/gui/settingsswitch.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4oRk87W4Q6haNCXlpS&open=AZ4oRk87W4Q6haNCXlpS&pullRequest=10031

Check warning on line 83 in src/gui/accountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this #include directive to the top of the file. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4mqr7A-Svkp3hBDNHP&open=AZ4mqr7A-Svkp3hBDNHP&pullRequest=10031

Check warning on line 505 in src/gui/accountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid this unnecessary copy by using a "const" reference. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4mqr7A-Svkp3hBDNHW&open=AZ4mqr7A-Svkp3hBDNHW&pullRequest=10031

Check warning on line 92 in src/gui/accountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4mqr7A-Svkp3hBDNHR&open=AZ4mqr7A-Svkp3hBDNHR&pullRequest=10031

Check warning on line 421 in src/gui/advancedsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace with the version of "std::ranges::any_of" that takes a range. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4mqrok-Svkp3hBDNGM&open=AZ4mqrok-Svkp3hBDNGM&pullRequest=10031

Check warning on line 506 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4mqrt5-Svkp3hBDNGf&open=AZ4mqrt5-Svkp3hBDNGf&pullRequest=10031

Check warning on line 4 in src/gui/infosettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4mqrtO-Svkp3hBDNGO&open=AZ4mqrtO-Svkp3hBDNGO&pullRequest=10031

Check warning on line 51 in src/gui/networksettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "->" with "::" for access to "Theme::doNotUseProxy". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4mqr8L-Svkp3hBDNHw&open=AZ4mqr8L-Svkp3hBDNHw&pullRequest=10031

Check warning on line 131 in src/gui/accountsettings.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4mqr0c-Svkp3hBDNHN&open=AZ4mqr0c-Svkp3hBDNHN&pullRequest=10031

Check warning on line 98 in src/gui/infosettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'const qsizetype' (aka 'const long long') to 'int' 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4mqrtO-Svkp3hBDNGP&open=AZ4mqrtO-Svkp3hBDNGP&pullRequest=10031

Check warning on line 75 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "widget" of type "const class QWidget *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4mqrt5-Svkp3hBDNGi&open=AZ4mqrt5-Svkp3hBDNGi&pullRequest=10031

Check warning on line 519 in src/gui/accountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "job" of type "class OCC::EncryptFolderJob *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4mqr7A-Svkp3hBDNHY&open=AZ4mqr7A-Svkp3hBDNHY&pullRequest=10031

Check warning on line 398 in src/gui/advancedsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function should be declared "const". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4mqrok-Svkp3hBDNGJ&open=AZ4mqrok-Svkp3hBDNGJ&pullRequest=10031

Check warning on line 468 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this variable a pointer-to-const. The current type of "infoSettingsPage" is "class OCC::InfoSettings *". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4mqrt5-Svkp3hBDNG9&open=AZ4mqrt5-Svkp3hBDNG9&pullRequest=10031

Check warning on line 63 in src/gui/settingsswitch.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses floating-point precision: 'double' to 'float' 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4raYCShzFqlqqr8wOm&open=AZ4raYCShzFqlqqr8wOm&pullRequest=10031

Check failure on line 56 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this macro by "const", "constexpr" or an "enum". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4mqrt5-Svkp3hBDNGd&open=AZ4mqrt5-Svkp3hBDNGd&pullRequest=10031

Check warning on line 1909 in src/gui/accountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this variable a pointer-to-const. The current type of "actionSetupE2e" is "class QAction *const". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4mqr7A-Svkp3hBDNHk&open=AZ4mqr7A-Svkp3hBDNHk&pullRequest=10031

Check warning on line 1313 in src/gui/accountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "networkSettingsLayout" of type "class QLayout *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4mqr7A-Svkp3hBDNHe&open=AZ4mqr7A-Svkp3hBDNHe&pullRequest=10031

Check warning on line 106 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace constant with "std::numbers::phi_v<float>". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4mqrt5-Svkp3hBDNGm&open=AZ4mqrt5-Svkp3hBDNGm&pullRequest=10031

Check warning on line 318 in src/gui/infosettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "notice" of type "class OCC::LegalNotice *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4mqrtO-Svkp3hBDNGb&open=AZ4mqrtO-Svkp3hBDNGb&pullRequest=10031

Check warning on line 297 in src/gui/infosettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function should be declared "const". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4mqrtO-Svkp3hBDNGZ&open=AZ4mqrtO-Svkp3hBDNGZ&pullRequest=10031
View more details on SonarQubeCloud