Handle non-blocking TLS read retries explicitly in ssl_read_internal#3322
Closed
Copilot wants to merge 1 commit intocopilot/sub-pr-3301from
Closed
Handle non-blocking TLS read retries explicitly in ssl_read_internal#3322Copilot wants to merge 1 commit intocopilot/sub-pr-3301from
ssl_read_internal#3322Copilot wants to merge 1 commit intocopilot/sub-pr-3301from
Conversation
5 tasks
Copilot
AI
changed the title
[WIP] Update ssl_read_internal for better flow
Handle non-blocking TLS read retries explicitly in Apr 15, 2026
ssl_read_internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ssl_read_internal.cpptreated any negative return frommbedtls_ssl_read()as the same error path. This PR narrows that behavior to correctly recognize non-blocking retry states (WANT_READ/WANT_WRITE) and preserve expected read flow.Behavioral correction
ret < 0handling with explicit checks for:MBEDTLS_ERR_SSL_WANT_READMBEDTLS_ERR_SSL_WANT_WRITEImpact scope
src/PAL/COM/sockets/ssl/MbedTLS/ssl_read_internal.cpp