Skip to content

Change in ssl_read_internal for better flow#3321

Closed
Copilot wants to merge 2 commits intoadd-pico-chibiosfrom
copilot/sub-pr-3301
Closed

Change in ssl_read_internal for better flow#3321
Copilot wants to merge 2 commits intoadd-pico-chibiosfrom
copilot/sub-pr-3301

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 15, 2026

  • Inspect new PR comment and confirm required code change in ssl_read_internal.cpp
  • Check GitHub Actions workflow runs for add-pico-chibios first (stacked PR base), then this branch if needed
  • Apply the requested mbedtls_ssl_read error handling condition change
  • Run targeted validation for the touched file/area
  • Reply to the PR comment with the addressing commit hash

Copilot AI changed the title [WIP] [WIP] Address feedback on Raspberry PICO RP2040 and RP2040_W with ChibiOS PR Create stacked PR branch targeting main to address review-thread follow-up Apr 15, 2026
Copilot AI requested a review from Ellerbach April 15, 2026 12:09
@Ellerbach
Copy link
Copy Markdown
Member

@copilot it's about bringing this change in this PR:

src/PAL/COM/sockets/ssl/MbedTLS/ssl_read_internal.cpp
int ret = mbedtls_ssl_read(ssl, (unsigned char *)(data), size);
- if (ret < 0)

+ if (ret == MBEDTLS_ERR_SSL_WANT_READ || ret == MBEDTLS_ERR_SSL_WANT_WRITE)

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 15, 2026

@copilot it's about bringing this change in this PR:

[src/PAL/COM/sockets/ssl/MbedTLS/ssl_read_internal.cpp](https://github.com/nanoframework/nf-interpreter/pull/3301/files/2fcc1229829cfcf83b57cbc7...

Applied in this PR branch at 1a607fc in src/PAL/COM/sockets/ssl/MbedTLS/ssl_read_internal.cpp with explicit MBEDTLS_ERR_SSL_WANT_READ/MBEDTLS_ERR_SSL_WANT_WRITE handling.

@Ellerbach Ellerbach marked this pull request as ready for review April 15, 2026 12:23
@Ellerbach Ellerbach requested a review from josesimoes April 15, 2026 12:23
@Ellerbach Ellerbach changed the title Create stacked PR branch targeting main to address review-thread follow-up Change in ssl_read_internal for better flow Apr 15, 2026
@Ellerbach
Copy link
Copy Markdown
Member

@copilot, close this one and open a new one against main with the same content

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 15, 2026

@Ellerbach I've opened a new pull request, #3322, to work on those changes. Once the pull request is ready, I'll request review from you.

@Ellerbach Ellerbach closed this Apr 15, 2026
@nfbot nfbot added the invalid label Apr 15, 2026
@networkfusion networkfusion deleted the copilot/sub-pr-3301 branch April 24, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants