TOOLS-4278 Convert mongoimport typed-fields tests to testify - #1064
Draft
autarch wants to merge 1 commit into
Draft
Conversation
The densest GoConvey file in the repo: 46 Convey blocks and 126 So call sites, almost all (input, expected) pairs. These collapse into table-driven cases, so the file gets shorter (450 -> 446 lines) while asserting exactly the same 184 runtime assertions. The pre-existing generic cast[T] helper keeps its type assertion as a reported failure rather than a panic; it just takes *testing.T now. Three cases skip the error check their sibling cases perform (fieldautoparser -2147483649, fieldint32parser -2147483648, fieldint64parser -2147483649), and NewFieldParser's error is discarded at every construction site. Both are preserved as-is rather than fixed, to keep this a mechanical refactor. Worth a follow-up. No behavior change.
This was referenced Jul 27, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The densest GoConvey file in the repo: 46 Convey blocks and 126 So call
sites, almost all (input, expected) pairs. These collapse into
table-driven cases, so the file gets shorter (450 -> 446 lines) while
asserting exactly the same 184 runtime assertions.
The pre-existing generic cast[T] helper keeps its type assertion as a
reported failure rather than a panic; it just takes *testing.T now.
Three cases skip the error check their sibling cases perform
(fieldautoparser -2147483649, fieldint32parser -2147483648,
fieldint64parser -2147483649), and NewFieldParser's error is discarded at
every construction site. Both are preserved as-is rather than fixed, to
keep this a mechanical refactor. Worth a follow-up.
No behavior change.