TOOLS-4278 Convert mongoimport csv tests to testify - #1063
Draft
autarch wants to merge 1 commit into
Draft
Conversation
Applies the migration conventions to mongoimport/csv_test.go: - Flattens the pure-wrapper top-level Convey in each Test* function and collapses same-shape nested Conveys into table-driven cases. - Collapses the UTF-8 BOM case's per-field comparison loop into a whole-document compare. The old loop ranged over the actual document and indexed into the expectation, so it never checked field count and would panic rather than fail on an extra field. 14 per-field checks become 4 strictly stronger ones. - Keeps the nested-field case field-by-field, because the reader decodes that value as *bson.D while the expectation is bson.D. Collapsing it would have meant rewriting the expectation and dropping its type assertion. No behavior change.
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the migration conventions to mongoimport/csv_test.go:
collapses same-shape nested Conveys into table-driven cases.
whole-document compare. The old loop ranged over the actual document
and indexed into the expectation, so it never checked field count and
would panic rather than fail on an extra field. 14 per-field checks
become 4 strictly stronger ones.
that value as *bson.D while the expectation is bson.D. Collapsing it
would have meant rewriting the expectation and dropping its type
assertion.
No behavior change.