Skip to content

file: make ErrTimeout unwrap os.ErrDeadlineExceeded #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alliasgher wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

file: make ErrTimeout unwrap os.ErrDeadlineExceeded #353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions file.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package winio
import (
"errors"
"io"
"os"
"runtime"
"sync"
"sync/atomic"
Expand All @@ -31,6 +32,10 @@ func (*timeoutError) Error() string { return "i/o timeout" }
func (*timeoutError) Timeout() bool { return true }
func (*timeoutError) Temporary() bool { return true }

// Unwrap returns os.ErrDeadlineExceeded so that errors.Is(err, os.ErrDeadlineExceeded)
// returns true for ErrTimeout, enabling interoperability with the standard library.
func (*timeoutError) Unwrap() error { return os.ErrDeadlineExceeded }

type timeoutChan chan struct{}

var ioInitOnce sync.Once
Expand Down