file: make ErrTimeout unwrap os.ErrDeadlineExceeded#353
Open
alliasgher wants to merge 1 commit intomicrosoft:mainfrom
Open
file: make ErrTimeout unwrap os.ErrDeadlineExceeded#353alliasgher wants to merge 1 commit intomicrosoft:mainfrom
alliasgher wants to merge 1 commit intomicrosoft:mainfrom
Conversation
timeoutError.Unwrap returns os.ErrDeadlineExceeded so that callers can use errors.Is(err, os.ErrDeadlineExceeded) for portability with the standard library and other packages that check for deadline errors. The ErrTimeout sentinel value and its Error/Timeout/Temporary methods are unchanged, so this is fully backwards compatible. Fixes microsoft#321 Signed-off-by: alliasgher <alliasgher123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #321. Adds
Unwrap() errortotimeoutErrorreturningos.ErrDeadlineExceeded, soerrors.Is(err, os.ErrDeadlineExceeded)works for interoperability with the standard library. Fully backwards-compatible — existingerrors.Is(err, ErrTimeout)checks continue to work.