Skip to content

fix(needs-review): handle null payload in visual helper toggle #7698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shirly8 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(needs-review): handle null payload in visual helper toggle #7698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/background/actions/needs-review-card-selection-action-creator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,16 @@ export class NeedsReviewCardSelectionActionCreator {
);
};

private onToggleVisualHelper = async (payload: VisualizationTogglePayload): Promise<void> => {
private onToggleVisualHelper = async (payload: VisualizationTogglePayload | null): Promise<void> => {
await this.needsReviewCardSelectionActions.toggleVisualHelper.invoke(null);
if (payload.enabled) {
await this.visualizationActions.disableVisualization.invoke(payload.test);
} else {
await this.visualizationActions.enableVisualization.invoke(payload);
if (payload && payload.enabled !== undefined && payload.test !== undefined) {
if (payload.enabled) {
await this.visualizationActions.disableVisualization.invoke(payload.test);
} else {
await this.visualizationActions.enableVisualization.invoke(payload);
}
this.telemetryEventHandler.publishTelemetry(TelemetryEvents.VISUAL_HELPER_TOGGLED, payload);
}
this.telemetryEventHandler.publishTelemetry(TelemetryEvents.VISUAL_HELPER_TOGGLED, payload);
};

private onCollapseAllRules = async (payload: BaseActionPayload): Promise<void> => {
Expand Down
33 changes: 32 additions & 1 deletion src/tests/unit/tests/background/actions/needs-review-card-selection-action-creator.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import * as TelemetryEvents from 'common/extension-telemetry-events';
import { Messages } from 'common/messages';
import { VisualizationType } from 'common/types/visualization-type';
import { MockInterpreter } from 'tests/unit/tests/background/global-action-creators/mock-interpreter';
import { IMock, Mock, Times } from 'typemoq';
import { IMock, It, Mock, Times } from 'typemoq';

import { createAsyncActionMock } from '../global-action-creators/action-creator-test-helpers';

Expand Down Expand Up @@ -141,6 +141,37 @@ describe('NeedsReviewCardSelectionActionCreator', () => {
visualizationActionsMock.verify(actions => actions['disableVisualization'], Times.once());
});

test('onToggleVisualHelper with null payload only toggles visual helper', async () => {
const toggleVisualHelperMock = createAsyncActionMock(null);
const actionsMock = createNeedsReviewActionsMock(
'toggleVisualHelper',
toggleVisualHelperMock.object,
);

const testSubject = new NeedsReviewCardSelectionActionCreator(
interpreterMock.object,
actionsMock.object,
visualizationActionsMock.object,
telemetryEventHandlerMock.object,
);

testSubject.registerCallbacks();

await interpreterMock.simulateMessage(
Messages.NeedsReviewCardSelection.ToggleVisualHelper,
null,
tabId,
);

toggleVisualHelperMock.verifyAll();
visualizationActionsMock.verify(actions => actions['enableVisualization'], Times.never());
visualizationActionsMock.verify(actions => actions['disableVisualization'], Times.never());
telemetryEventHandlerMock.verify(
handler => handler.publishTelemetry(It.isAny(), It.isAny()),
Times.never(),
);
});

test('onCollapseAllRules', async () => {
const payloadStub: BaseActionPayload = {};
const collapseAllRulesActionMock = createAsyncActionMock(null);
Expand Down