fix(needs-review): handle null payload in visual helper toggle#7698
Open
Shirly8 wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(needs-review): handle null payload in visual helper toggle#7698Shirly8 wants to merge 1 commit intomicrosoft:mainfrom
Shirly8 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6253 - Can't toggle off from the ad-hoc panel if you've toggled on in DetailsView
Changes
onToggleVisualHelperinneeds-review-card-selection-action-creator.tsto acceptnullpayloadsnull(called fromaction-creator.ts), only toggle visual helper state without trying to enable/disable visualizationTesting
toggleVisualHelperis called withnull, it only toggles the visual helper state and doesn't try to enable/disable the visualizationRoot Cause
When toggling the Needs Review visualization ON in DetailsView,
action-creator.tscallstoggleVisualHelper.invoke(null)to sync the visual helper state. However,onToggleVisualHelperwas trying to accesspayload.enabledwhich doesn't exist when payload isnull, causing the toggle to get stuck in the ad-hoc panel.