Upgrade GitHub Actions versions and pin with SHA hashes#6719
Merged
Upgrade GitHub Actions versions and pin with SHA hashes#6719
Conversation
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
sh-cho
requested review from
ikhoon,
jrhee17,
minwoox and
trustin
as code owners
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
✅ Files skipped from review due to trivial changes (7)
📝 WalkthroughWalkthroughPins third-party GitHub Actions to specific commit SHAs across many workflows and adds a 7-day Dependabot cooldown for Gradle, GitHub Actions, and npm updates; no runtime code or public API changes. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.github/workflows/publish-release.yml (1)
51-53: Explicitly disable npm cache in Node setup for release job handling secrets.While auto-caching won't be triggered in this repository (no package.json with packageManager field), explicitly setting
package-manager-cache: falsehardens the job configuration. Since this step follows Maven publication using sensitive credentials, being explicit about cache behavior prevents accidental caching of sensitive files or credentials.Proposed change
- name: Setup Node.js uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 with: node-version: 18 + package-manager-cache: false🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/publish-release.yml around lines 51 - 53, Update the actions/setup-node step to explicitly disable the npm/package-manager cache by adding package-manager-cache: false to the step configuration; locate the actions/setup-node@... step (the one with node-version: 18) and add the package-manager-cache: false key so the Node setup does not create or use a package manager cache after the Maven publish step..github/workflows/gradle-enterprise-postjob.yml (1)
94-96: Explicitly disable npm cache in this tokenized workflow.This workflow uses secrets (
DEVELOCITY_ACCESS_KEY,GITHUB_TOKEN), and npm caching should be controlled explicitly for security. Setpackage-manager-cache: falseunless caching is specifically required.Proposed change
- name: Setup Node.js uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 with: node-version: 18 + package-manager-cache: false🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/gradle-enterprise-postjob.yml around lines 94 - 96, The workflow uses actions/setup-node with node-version: 18 but doesn't explicitly disable npm package caching; update the setup step where actions/setup-node is configured (the block containing "uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f" and "with: node-version: 18") to add package-manager-cache: false so npm caching is explicitly disabled in this tokenized workflow.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/gradle-cache-check.yml:
- Around line 22-33: The workflow uses mutable action refs (the three
occurrences of "uses:
gradle/develocity-build-validation-scripts/.github/actions/gradle/...@actions-stable")
which should be pinned to immutable 40-character commit SHAs; update each "uses"
entry (the download, experiment-1, and experiment-3 actions) to replace
"@actions-stable" with the exact commit SHA for that action and add an inline
comment indicating the original "@actions-stable" tag for traceability.
---
Nitpick comments:
In @.github/workflows/gradle-enterprise-postjob.yml:
- Around line 94-96: The workflow uses actions/setup-node with node-version: 18
but doesn't explicitly disable npm package caching; update the setup step where
actions/setup-node is configured (the block containing "uses:
actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f" and "with:
node-version: 18") to add package-manager-cache: false so npm caching is
explicitly disabled in this tokenized workflow.
In @.github/workflows/publish-release.yml:
- Around line 51-53: Update the actions/setup-node step to explicitly disable
the npm/package-manager cache by adding package-manager-cache: false to the step
configuration; locate the actions/setup-node@... step (the one with
node-version: 18) and add the package-manager-cache: false key so the Node setup
does not create or use a package manager cache after the Maven publish step.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 54f58a38-caa1-4994-9b6f-631a99fc642d
📒 Files selected for processing (12)
.github/dependabot.yml.github/workflows/actions_build.yml.github/workflows/e2e-chaos-tests.yml.github/workflows/gradle-cache-check.yml.github/workflows/gradle-enterprise-postjob.yml.github/workflows/pr-stale.yml.github/workflows/public-suffixes.yml.github/workflows/publish-release.yml.github/workflows/publish-site.yml.github/workflows/tag-new-release.yml.github/workflows/xds-apply-updates.yml.github/workflows/xds-compare-versions.yml
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
Contributor
minwoox
approved these changes
Apr 14, 2026
Contributor
minwoox
left a comment
minwoox
left a comment
There was a problem hiding this comment.
Thanks a lot!
gradle/actions is kept at v5.x. I think upgrading to v6 should be revisited once maintainers have reviewed the licensing implications
Yeah, let us discuss and upgrade if there's no issue.
Contributor
Would you mind updating it? |
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
Contributor
Author
|
@minwoox done :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Keep GitHub Actions dependencies up-to-date and secure by upgrading to the latest versions with pinned SHA hashes.
Modifications:
Result: