Expand Fluent localization to 34 locales (#466)

.codescene/code-health-rules.json

@@ -0,0 +1,15 @@
+{
+  "usage": "Repo-scoped CodeScene overrides. Keep each rule_set narrowly scoped and justify it in matching_content_path_doc, so a reader can tell a deliberate exemption from an unexamined one.",
+  "rule_sets": [
+    {
+      "matching_content_path": "build_l10n_audit/**",
+      "matching_content_path_doc": "Hand-rolled scanners over borrowed source text. These modules parse the define_keys! macro, the Fluent catalogues, and the Cargo metadata without taking a parser dependency into the build script, so their helpers necessarily take &str views into a buffer the caller owns: a line and its trimmed form, a message body, a table. Grouping those borrows into a context type would add a value that is constructed once and immediately unpacked at each call site, and taking String instead would allocate per line across 35 catalogues while breaking the borrowed returns. Each helper is private, called only from its own module, and reachable from a single entry point (parse_catalogue, extract_key_constants, parse_metadata_locales), so the parameter grouping is visible at a glance rather than spread across an API. Reassess if these parsers grow beyond one screen each or gain external callers.",
+      "rules": [
+        {
+          "name": "String Heavy Function Arguments",
+          "weight": 0.0
+        }
+      ]
+    }
+  ]
+}

CHANGELOG.md

@@ -2,8 +2,30 @@
 
 ## Unreleased
 
+### Added
+
+- Ship 33 further locale catalogues, so `--locale` now selects any of `ar`,
+  `cs`, `cy`, `da`, `de`, `el`, `en-GB`, `en-US`, `es-419`, `es-ES`, `fa`, `fi`,
+  `fr`, `gd`, `he`, `hi`, `hu`, `id`, `it`, `ja`, `ko`, `nb`, `nl`, `pl`,
+  `pt-BR`, `pt-PT`, `ro`, `ru`, `sv`, `th`, `tr`, `uk`, `vi`, `zh-Hans` or
+  `zh-Hant`, with `en-US` remaining the source and fallback locale
+  ([#466](https://github.com/leynos/netsuke/issues/466))
+
 ### Changed
 
+- Select catalogues by exact locale tag with deliberate per-language fallback
+  rules, so `es-419` and `es-ES`, `pt-BR` and `pt-PT`, and `zh-Hans` and
+  `zh-Hant` stay distinct instead of collapsing onto one catalogue per language
+  ([#466](https://github.com/leynos/netsuke/issues/466))
+- Make `src/locale_catalogues.rs` the authoritative locale registry, read by
+  the embedded catalogues, the build-time audit, the `rerun-if-changed`
+  directives, packaging, and the tests; the build now fails if `Cargo.toml`'s
+  `ortho_config` locale metadata drifts from it
+  ([#466](https://github.com/leynos/netsuke/issues/466))
+- Extend the build-time localization audit to every declared locale and to
+  interpolation variables, so a message that drops or invents a `{ $variable }`
+  fails the build ([#466](https://github.com/leynos/netsuke/issues/466))
+
 - Route graph-view node registration through a borrow-returning
   `NodePathRegistry` accessor that looks paths up once on hits and clones a
   path only on insertion ([#465](https://github.com/leynos/netsuke/issues/465))

Cargo.toml

@@ -9,7 +9,7 @@ include = [
     "README.md",
     "LICENSE",
     "build.rs",
-    "build_l10n_audit.rs",
+    "build_l10n_audit/**",
 ]
 license = "ISC"
 readme = "README.md"
@@ -22,7 +22,43 @@ categories = ["command-line-utilities", "development-tools::build-utils"]
 
 [package.metadata.ortho_config]
 root_type = "netsuke::cli::CliConfig"
-locales   = ["en-US", "es-ES"]
+locales   = [
+    "ar",
+    "cs",
+    "cy",
+    "da",
+    "de",
+    "el",
+    "en-GB",
+    "en-US",
+    "es-419",
+    "es-ES",
+    "fa",
+    "fi",
+    "fr",
+    "gd",
+    "he",
+    "hi",
+    "hu",
+    "id",
+    "it",
+    "ja",
+    "ko",
+    "nb",
+    "nl",
+    "pl",
+    "pt-BR",
+    "pt-PT",
+    "ro",
+    "ru",
+    "sv",
+    "th",
+    "tr",
+    "uk",
+    "vi",
+    "zh-Hans",
+    "zh-Hant",
+]
 
 [package.metadata.kani.flags]
 default-unwind = "6"
@@ -172,6 +208,11 @@ strip-ansi-escapes = "0.2"
 toml = "0.8"
 serde_yaml = "0.9"
 proptest = "1.11.0"
+# Plural-selection tests must pass numeric arguments to Fluent. `ortho_config`
+# exposes `LocalizationArgs` as a map of `FluentValue`, but does not re-export
+# the value type, so the tests need `fluent-bundle` directly. Constrained to
+# the version `ortho_config` resolves, or the `FluentValue` types would differ.
+fluent-bundle = "0.16.0"
 
 # Target-specific dev-deps
 [target.'cfg(unix)'.dev-dependencies]

build.rs

@@ -49,8 +49,25 @@ mod cli_l10n;
 #[path = "src/host_pattern.rs"]
 mod host_pattern;
 
+/// The locale registry, shared with the library crate.
+///
+/// Both `localization` and the audit reach the registry through
+/// `crate::locale_catalogues`, so it is declared at this crate's root under
+/// that name. It is public because `localization` re-exports it, and a private
+/// module cannot be re-exported from a public path. The build script itself
+/// reads `SUPPORTED_LOCALES` to emit one `rerun-if-changed` directive per
+/// catalogue.
+#[path = "src/locale_catalogues.rs"]
+pub mod locale_catalogues;
+
+/// Message rendering, shared with the library crate.
+///
+/// Exposed as `crate::localization`, which `cli`, `cli_l10n`, and
+/// `host_pattern` reach for `localization::keys` when building the clap
+/// command for man-page generation. Public so its `locales` re-export stays
+/// reachable at `crate::localization::locales`.
 #[path = "src/localization/mod.rs"]
-mod localization;
+pub mod localization;
 
 #[expect(
     dead_code,
@@ -136,8 +153,16 @@ fn emit_rerun_directives() {
     println!("cargo:rerun-if-env-changed=TARGET");
     println!("cargo:rerun-if-env-changed=PROFILE");
     println!("cargo:rerun-if-changed=src/localization/keys.rs");
-    println!("cargo:rerun-if-changed=locales/en-US/messages.ftl");
-    println!("cargo:rerun-if-changed=locales/es-ES/messages.ftl");
+    println!("cargo:rerun-if-changed=src/locale_catalogues.rs");
+    println!("cargo:rerun-if-changed=Cargo.toml");
+    // The locale registry owns the catalogue list, so the rerun directives are
+    // derived from it rather than repeated by hand.
+    for entry in locale_catalogues::SUPPORTED_LOCALES {
+        println!(
+            "cargo:rerun-if-changed={}",
+            build_l10n_audit::catalogue_path(entry.tag()).display()
+        );
+    }
 }
 
 #[expect(