Establish canonical app structure vocabulary - #199
Merged
Conversation
Owner
Author
Work intentphase: completed
summary: "Landed the canonical first-level app structure vocabulary as the naming-only foundation for #195."
touch-points:
- AGENTS.md
- GLOSSARY.md
- DECISIONS.md
- doc/design/
- doc/plans/
- docs/developer/app-structure.md
- docs/user/
- src/index.html
- src/renderer.ts
- src/contracts.ts
- src/ipc-contract.ts
- src/navigation.ts
- src/review-sessions.ts
- src/settings.ts
- src/workspace-state.ts
- src/styles.css
- focused structure, navigation, settings, workspace, and UI tests
done-when:
- "The six approved first-level terms are canonical across glossary, docs, DOM, TypeScript, CSS, settings, private state, and tests."
- "The app shell and app header have truthful DOM boundaries."
- "The ELI5 structure document verifies as self-contained."
- "Existing pre-UI computed palette values are preserved."
- "Current-head CI and automated review are green and the PR is merged before #195."
excludes:
- "Claude UI color, typography, spacing, selection, scrollbar, token-tuner, and window-geometry tweaks."
- "Naming pane contents, dialogs, settings organization, overlays, or child components."
- "Color consolidation or other new visual decisions."
- "Compatibility aliases or migrations for unreleased pre-MVP private UI state."
blocked-by: []
may-block:
- "#195"
branch: "t3code/canonical-app-structure" |
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delivery order
This naming-only PR lands before #195. The inherited UI tweaks will then be rebuilt on this vocabulary and audited against it.
Validation
npm run buildgit diff --checkremote-creation-journal.test, which passes when run aloneBoundary
This PR changes names and architecture boundaries, not visual choices. It preserves the existing base and Olive-light computed pane/header colors. It excludes Claude’s UI color, typography, spacing, selection-bridge, scrollbar, tuner, and window-geometry tweaks, which remain in #195.