Improve Markover review UI - #195
Draft
lastobelus wants to merge 2 commits into
Draft
Conversation
This was referenced Aug 21, 2026
Owner
Author
Work intentphase: review
summary: "PR #195 is rebased onto current main; the floating theme-token inspector is naming-clean, semantically scoped, fully validated, and ready to open for human QA."
touch-points:
- docs/developer/app-structure.md
- src/index.html
- src/renderer.ts
- src/styles.css
- test/brand.test.ts
- tmp/pr-195-dev-checklist.md
done-when:
- "PR #195 is rebased onto the current origin/main without losing inherited UI behavior."
- "The floating inspector displays canonical App shell, App header, Left pane, Center pane, and Right pane structural tokens."
- "Structural semantic tokens use the documented prefixes and the inspector's own styling uses theme-token-inspector component roles."
- "Displayed token values refresh from live computed custom properties across palette and appearance changes."
- "Focused tests and npm run ci:local pass."
- "The PR-specific development review opens successfully for human QA."
excludes:
- "Naming the next content/component layer outside the floating inspector."
- "New palette color consolidation or visual redesign."
- "Merging PR #195."
blocked-by:
- "A user-confirmed QA window is required before launching or focusing the development app."
may-block: []
branch: "t3code/improve-markover-ui" |
This was referenced Aug 21, 2026
lastobelus
force-pushed
the
t3code/improve-markover-ui
branch
from
August 21, 2026 18:47
7973fad to
110c17a
Compare
Squash the Claude-driven incremental UI series into one net change so it can be rebased cleanly onto the canonical app structure vocabulary.
lastobelus
force-pushed
the
t3code/improve-markover-ui
branch
from
August 21, 2026 23:35
110c17a to
7769796
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Claude’s incremental UI experiment is rebuilt on the canonical app-structure vocabulary landed in #199 and rebased onto current
main.The inherited UI changes include:
Naming and theme-token foundation
#199 owns the canonical names: App shell, App header, Pane layout, Left pane, Center pane, and Right pane. This PR uses those names throughout its DOM, TypeScript, CSS, settings, tests, and structural semantic tokens.
The floating development palette is consistently named the theme-token inspector so it does not collide with Markover’s Ember/Ocean/Olive palette setting. It:
--theme-token-inspector-*component roles--app-header-backgroundThe architecture documentation now records this PR’s current structural color mappings.
Validation
npm run ci:localStatus
Draft while human UI QA continues.
🤖 Original incremental UI work generated with Claude Code; branch split, rebase, naming alignment, and token audit completed with Codex.