Skip to content

add banner for ai engineer sf #3194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leonardwolters wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −17
Open

add banner for ai engineer sf #3194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions components/layout/Banner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,21 @@
import { Banner as FumadocsBanner } from "fumadocs-ui/components/banner";

export function Banner() {
return null;
// return (
// <FumadocsBanner
// id="fd-top-banner-town-hall-2026-q2"
// height="2rem"
// className="bg-black text-white [&_a]:text-white [&_button]:text-white"
// >
// <Link href="https://luma.com/7dny2x72">
// <span className="sm:hidden">
// [Virtual] Langfuse Town Hall · Jun 11 →
// </span>
// <span className="hidden sm:inline">
// [Virtual] Langfuse Town Hall · Jun 11, 9am PT: V4, Releases, Roadmap →
// </span>
// </Link>
// </FumadocsBanner>
// );
return (
<FumadocsBanner
id="fd-top-banner-ai-engineer-world-fair-2026"
height="2rem"
className="bg-black text-white [&_a]:text-white [&_button]:text-white"
>
<Link href="https://www.ai.engineer/worldsfair">
<span className="sm:hidden">
Langfuse @ AI Engineer · Booth LG-39 →
</span>
<span className="hidden sm:inline">
Langfuse @ AI Engineer World Fair in San Francisco · Find us at booth
LG-39 →

Check warning on line 17 in components/layout/Banner.tsx

View check run for this annotation

Claude / Claude Code Review

Incorrect event name: missing apostrophe-s in "World's Fair" 

The desktop banner reads "AI Engineer World Fair" but the canonical event name is "AI Engineer World's Fair" (apostrophe-s). The URL slug `/worldsfair` reflects this, and the existing reference in `content/blog/2026-04-30-langfuse-april-update.mdx:105` already uses the canonical form. Suggest: `Langfuse @ AI Engineer World's Fair in San Francisco · Find us at booth LG-39 →`.
Comment on lines +16 to +17

@claude claude Bot Jun 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 The desktop banner reads "AI Engineer World Fair" but the canonical event name is "AI Engineer World's Fair" (apostrophe-s). The URL slug /worldsfair reflects this, and the existing reference in content/blog/2026-04-30-langfuse-april-update.mdx:105 already uses the canonical form. Suggest: Langfuse @ AI Engineer World's Fair in San Francisco · Find us at booth LG-39 →.

Extended reasoning...

What the bug is

The site-wide top banner introduced in this PR reads Langfuse @ AI Engineer World Fair in San Francisco (desktop variant in components/layout/Banner.tsx:16-17). The official conference name is AI Engineer World's Fair — with apostrophe-s — not World Fair.

Evidence the canonical name has the apostrophe-s

  1. The link target in this same banner is https://www.ai.engineer/worldsfair — the conference organizer's own URL slug is worldsfair (i.e. world's fair), not worldfair.
  2. The Langfuse repo already uses the canonical name elsewhere. content/blog/2026-04-30-langfuse-april-update.mdx:105 reads: [AI Engineer World's Fair](https://www.ai.engineer/worldsfair), SF — June 29 – July 2, 2026. This PR is inconsistent with the codebase's own existing reference.

Step-by-step proof

  1. Open components/layout/Banner.tsx on this branch.
  2. Line 17 (desktop <span className="hidden sm:inline">): Langfuse @ AI Engineer World Fair in San Francisco · Find us at booth LG-39 →.
  3. Run grep -rn "World's Fair" content/ → match at content/blog/2026-04-30-langfuse-april-update.mdx:105 showing the apostrophe-s form already in use.
  4. Visit the link https://www.ai.engineer/worldsfair → the URL slug confirms world's fair.
  5. Result: the banner copy disagrees with both the existing internal reference and the event's own URL.

Impact

This banner sits at the top of every docs page, so the misnamed event is the most prominent piece of marketing copy on the site for the duration of the campaign (~SF event week). The misnaming is purely cosmetic — no functional impact — but it's a public, branded reference and easy to get right.

How to fix

Change line 17 from AI Engineer World Fair to AI Engineer World's Fair. The mobile variant on line 14 (Langfuse @ AI Engineer · Booth LG-39 →) omits the event name entirely, so it does not need changes. Optionally update the banner id (fd-top-banner-ai-engineer-world-fair-2026) for internal consistency, but this is not user-visible.

</span>
</Link>
</FumadocsBanner>
);
}
Loading