Skip to content

add banner for ai engineer sf#3194

Open
leonardwolters wants to merge 1 commit into
mainfrom
add-ai-eng-banner
Open

add banner for ai engineer sf#3194
leonardwolters wants to merge 1 commit into
mainfrom
add-ai-eng-banner

Conversation

@leonardwolters

@leonardwolters leonardwolters commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Greptile Summary

This PR replaces the previous (commented-out, inactive) Town Hall banner with a live promotional banner for the AI Engineer World Fair in San Francisco, pointing to booth LG-39. The old return null is removed and the component now renders an active FumadocsBanner with responsive text and a link to https://www.ai.engineer/worldsfair.

  • The banner id changes from fd-top-banner-town-hall-2026-q2 to fd-top-banner-ai-engineer-world-fair-2026, so returning visitors who dismissed the previous banner will see this one fresh.
  • Unlike the Town Hall banner, no event date is shown in the banner text — visitors cannot tell when the event is happening without clicking through to the link.

Confidence Score: 5/5

This is a safe, self-contained swap of one promotional banner for another with no logic changes.

The change activates a new banner by replacing return null with a properly structured FumadocsBanner JSX block. The new banner id is unique, the responsive text variants follow the same pattern as the previous banner, and the external link target looks correct. The only notable omission is that no event date appears in the banner copy, but that is cosmetic and does not affect functionality.

No files require special attention.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Banner component renders] --> B{FumadocsBanner id\nfd-top-banner-ai-engineer-world-fair-2026}
    B --> C{Viewport size}
    C -- "sm:hidden\n(mobile)" --> D["Langfuse @ AI Engineer · Booth LG-39 →"]
    C -- "hidden sm:inline\n(desktop)" --> E["Langfuse @ AI Engineer World Fair in San Francisco · Find us at booth LG-39 →"]
    D --> F[Link → https://www.ai.engineer/worldsfair]
    E --> F
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[Banner component renders] --> B{FumadocsBanner id\nfd-top-banner-ai-engineer-world-fair-2026}
    B --> C{Viewport size}
    C -- "sm:hidden\n(mobile)" --> D["Langfuse @ AI Engineer · Booth LG-39 →"]
    C -- "hidden sm:inline\n(desktop)" --> E["Langfuse @ AI Engineer World Fair in San Francisco · Find us at booth LG-39 →"]
    D --> F[Link → https://www.ai.engineer/worldsfair]
    E --> F
Loading
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
components/layout/Banner.tsx:13-17
**Missing event date in banner text**

The Town Hall banner included an explicit date ("Jun 11, 9am PT") so visitors immediately knew whether the event was upcoming or already past. This banner omits any date, so users have no way to know when the World Fair is happening without clicking through to the external link. Consider adding the event dates (e.g., "Jun 28–29") to at least the desktop span.

Reviews (1): Last reviewed commit: "add banner for ai engineer sf" | Re-trigger Greptile

@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 26, 2026
@vercel

vercel Bot commented Jun 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
langfuse-docs Ready Ready Preview, Comment Jun 26, 2026 3:03pm

Request Review

@github-actions

Copy link
Copy Markdown

@claude review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward banner enable for the AI Engineer SF event; worth fixing the inline nit ("World's Fair") before merging since the banner is site-wide.

Extended reasoning...

Overview

Single-file change to components/layout/Banner.tsx that flips the site-wide top banner from a commented-out Town Hall promo to an active AI Engineer World's Fair / Booth LG-39 promo. The structure mirrors the previous Town Hall banner exactly (FumadocsBanner with mobile/desktop variants), only the id, link target, and copy change.

Security risks

None. No new dependencies, no user input, no auth/permissions changes. The new <Link> target (https://www.ai.engineer/worldsfair) is a static external URL to the well-known conference site.

Level of scrutiny

Very low. This is marketing copy in a docs site banner — purely cosmetic, no logic, no data flow. The diff is essentially a content swap inside an existing component shape.

Other factors

One inline nit was raised: the desktop copy reads "AI Engineer World Fair" but the canonical name (and the existing reference in content/blog/2026-04-30-langfuse-april-update.mdx, plus the link slug /worldsfair) is "World's Fair". Since the banner sits at the top of every docs page during the campaign, the author should fix the apostrophe-s before merging, but it doesn't warrant blocking automated approval.

Comment on lines +16 to +17
Langfuse @ AI Engineer World Fair in San Francisco · Find us at booth
LG-39

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 The desktop banner reads "AI Engineer World Fair" but the canonical event name is "AI Engineer World's Fair" (apostrophe-s). The URL slug /worldsfair reflects this, and the existing reference in content/blog/2026-04-30-langfuse-april-update.mdx:105 already uses the canonical form. Suggest: Langfuse @ AI Engineer World's Fair in San Francisco · Find us at booth LG-39 →.

Extended reasoning...

What the bug is

The site-wide top banner introduced in this PR reads Langfuse @ AI Engineer World Fair in San Francisco (desktop variant in components/layout/Banner.tsx:16-17). The official conference name is AI Engineer World's Fair — with apostrophe-s — not World Fair.

Evidence the canonical name has the apostrophe-s

  1. The link target in this same banner is https://www.ai.engineer/worldsfair — the conference organizer's own URL slug is worldsfair (i.e. world's fair), not worldfair.
  2. The Langfuse repo already uses the canonical name elsewhere. content/blog/2026-04-30-langfuse-april-update.mdx:105 reads: [AI Engineer World's Fair](https://www.ai.engineer/worldsfair), SF — June 29 – July 2, 2026. This PR is inconsistent with the codebase's own existing reference.

Step-by-step proof

  1. Open components/layout/Banner.tsx on this branch.
  2. Line 17 (desktop <span className="hidden sm:inline">): Langfuse @ AI Engineer World Fair in San Francisco · Find us at booth LG-39 →.
  3. Run grep -rn "World's Fair" content/ → match at content/blog/2026-04-30-langfuse-april-update.mdx:105 showing the apostrophe-s form already in use.
  4. Visit the link https://www.ai.engineer/worldsfair → the URL slug confirms world's fair.
  5. Result: the banner copy disagrees with both the existing internal reference and the event's own URL.

Impact

This banner sits at the top of every docs page, so the misnamed event is the most prominent piece of marketing copy on the site for the duration of the campaign (~SF event week). The misnaming is purely cosmetic — no functional impact — but it's a public, branded reference and easy to get right.

How to fix

Change line 17 from AI Engineer World Fair to AI Engineer World's Fair. The mobile variant on line 14 (Langfuse @ AI Engineer · Booth LG-39 →) omits the event name entirely, so it does not need changes. Optionally update the banner id (fd-top-banner-ai-engineer-world-fair-2026) for internal consistency, but this is not user-visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant