add banner for ai engineer sf#3194
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@claude review |
There was a problem hiding this comment.
LGTM — straightforward banner enable for the AI Engineer SF event; worth fixing the inline nit ("World's Fair") before merging since the banner is site-wide.
Extended reasoning...
Overview
Single-file change to components/layout/Banner.tsx that flips the site-wide top banner from a commented-out Town Hall promo to an active AI Engineer World's Fair / Booth LG-39 promo. The structure mirrors the previous Town Hall banner exactly (FumadocsBanner with mobile/desktop variants), only the id, link target, and copy change.
Security risks
None. No new dependencies, no user input, no auth/permissions changes. The new <Link> target (https://www.ai.engineer/worldsfair) is a static external URL to the well-known conference site.
Level of scrutiny
Very low. This is marketing copy in a docs site banner — purely cosmetic, no logic, no data flow. The diff is essentially a content swap inside an existing component shape.
Other factors
One inline nit was raised: the desktop copy reads "AI Engineer World Fair" but the canonical name (and the existing reference in content/blog/2026-04-30-langfuse-april-update.mdx, plus the link slug /worldsfair) is "World's Fair". Since the banner sits at the top of every docs page during the campaign, the author should fix the apostrophe-s before merging, but it doesn't warrant blocking automated approval.
| Langfuse @ AI Engineer World Fair in San Francisco · Find us at booth | ||
| LG-39 → |
There was a problem hiding this comment.
🟡 The desktop banner reads "AI Engineer World Fair" but the canonical event name is "AI Engineer World's Fair" (apostrophe-s). The URL slug /worldsfair reflects this, and the existing reference in content/blog/2026-04-30-langfuse-april-update.mdx:105 already uses the canonical form. Suggest: Langfuse @ AI Engineer World's Fair in San Francisco · Find us at booth LG-39 →.
Extended reasoning...
What the bug is
The site-wide top banner introduced in this PR reads Langfuse @ AI Engineer World Fair in San Francisco (desktop variant in components/layout/Banner.tsx:16-17). The official conference name is AI Engineer World's Fair — with apostrophe-s — not World Fair.
Evidence the canonical name has the apostrophe-s
- The link target in this same banner is
https://www.ai.engineer/worldsfair— the conference organizer's own URL slug isworldsfair(i.e.world's fair), notworldfair. - The Langfuse repo already uses the canonical name elsewhere.
content/blog/2026-04-30-langfuse-april-update.mdx:105reads:[AI Engineer World's Fair](https://www.ai.engineer/worldsfair), SF — June 29 – July 2, 2026. This PR is inconsistent with the codebase's own existing reference.
Step-by-step proof
- Open
components/layout/Banner.tsxon this branch. - Line 17 (desktop
<span className="hidden sm:inline">):Langfuse @ AI Engineer World Fair in San Francisco · Find us at booth LG-39 →. - Run
grep -rn "World's Fair" content/→ match atcontent/blog/2026-04-30-langfuse-april-update.mdx:105showing the apostrophe-s form already in use. - Visit the link
https://www.ai.engineer/worldsfair→ the URL slug confirmsworld's fair. - Result: the banner copy disagrees with both the existing internal reference and the event's own URL.
Impact
This banner sits at the top of every docs page, so the misnamed event is the most prominent piece of marketing copy on the site for the duration of the campaign (~SF event week). The misnaming is purely cosmetic — no functional impact — but it's a public, branded reference and easy to get right.
How to fix
Change line 17 from AI Engineer World Fair to AI Engineer World's Fair. The mobile variant on line 14 (Langfuse @ AI Engineer · Booth LG-39 →) omits the event name entirely, so it does not need changes. Optionally update the banner id (fd-top-banner-ai-engineer-world-fair-2026) for internal consistency, but this is not user-visible.
Greptile Summary
This PR replaces the previous (commented-out, inactive) Town Hall banner with a live promotional banner for the AI Engineer World Fair in San Francisco, pointing to booth LG-39. The old
return nullis removed and the component now renders an activeFumadocsBannerwith responsive text and a link tohttps://www.ai.engineer/worldsfair.fd-top-banner-town-hall-2026-q2tofd-top-banner-ai-engineer-world-fair-2026, so returning visitors who dismissed the previous banner will see this one fresh.Confidence Score: 5/5
This is a safe, self-contained swap of one promotional banner for another with no logic changes.
The change activates a new banner by replacing return null with a properly structured FumadocsBanner JSX block. The new banner id is unique, the responsive text variants follow the same pattern as the previous banner, and the external link target looks correct. The only notable omission is that no event date appears in the banner copy, but that is cosmetic and does not affect functionality.
No files require special attention.
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Banner component renders] --> B{FumadocsBanner id\nfd-top-banner-ai-engineer-world-fair-2026} B --> C{Viewport size} C -- "sm:hidden\n(mobile)" --> D["Langfuse @ AI Engineer · Booth LG-39 →"] C -- "hidden sm:inline\n(desktop)" --> E["Langfuse @ AI Engineer World Fair in San Francisco · Find us at booth LG-39 →"] D --> F[Link → https://www.ai.engineer/worldsfair] E --> F%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% flowchart TD A[Banner component renders] --> B{FumadocsBanner id\nfd-top-banner-ai-engineer-world-fair-2026} B --> C{Viewport size} C -- "sm:hidden\n(mobile)" --> D["Langfuse @ AI Engineer · Booth LG-39 →"] C -- "hidden sm:inline\n(desktop)" --> E["Langfuse @ AI Engineer World Fair in San Francisco · Find us at booth LG-39 →"] D --> F[Link → https://www.ai.engineer/worldsfair] E --> FPrompt To Fix All With AI
Reviews (1): Last reviewed commit: "add banner for ai engineer sf" | Re-trigger Greptile