Skip to content

fix(v21): close bilingual Product final CI routes #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laiqian0239-glitch merged 2 commits into from
Aug 15, 2026
Merged

fix(v21): close bilingual Product final CI routes #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78e31a7
test(v21): reproduce bilingual Product final CI route gaps
laiqian0239-glitch Aug 15, 2026
1cca222
fix(v21): close exact Product final CI routes
laiqian0239-glitch Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions .github/workflows/v21-product-experience-shell-p0-final-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,16 @@ permissions:
contents: read

env:
PRODUCT_BRANCH: product/v21-product-experience-shell-p0
PRODUCT_BRANCH: ${{ github.event.pull_request.head.ref }}

jobs:
frozen-element-reproducibility:
if: >-
github.event.pull_request.head.repo.full_name == github.repository &&
github.event.pull_request.head.ref == 'product/v21-product-experience-shell-p0'
(
github.event.pull_request.head.ref == 'product/v21-product-experience-shell-p0' ||
github.event.pull_request.head.ref == 'product/v21-product-experience-bilingual-search-translation-task-ux-p0'
)
runs-on: windows-latest
env:
CANDIDATE_SHA: ${{ github.event.pull_request.head.sha }}
Expand Down Expand Up @@ -110,7 +113,10 @@ jobs:
materialized-desktop-uat:
if: >-
github.event.pull_request.head.repo.full_name == github.repository &&
github.event.pull_request.head.ref == 'product/v21-product-experience-shell-p0'
(
github.event.pull_request.head.ref == 'product/v21-product-experience-shell-p0' ||
github.event.pull_request.head.ref == 'product/v21-product-experience-bilingual-search-translation-task-ux-p0'
)
runs-on: windows-latest
timeout-minutes: 120
env:
Expand Down Expand Up @@ -415,7 +421,10 @@ jobs:
materialized-matrix-uat:
if: >-
github.event.pull_request.head.repo.full_name == github.repository &&
github.event.pull_request.head.ref == 'product/v21-product-experience-shell-p0'
(
github.event.pull_request.head.ref == 'product/v21-product-experience-shell-p0' ||
github.event.pull_request.head.ref == 'product/v21-product-experience-bilingual-search-translation-task-ux-p0'
)
runs-on: ubuntu-latest
timeout-minutes: 120
env:
Expand Down
1 change: 1 addition & 0 deletions governance/layered-ci/wp0-routing-policy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@
"integration/element-module/src/VoiceWorkspace.css",
"integration/element-module/src/VoiceWorkspace.tsx",
"config/upstreams/v21-product-experience-shell-p0.json",
"integration/element-module/src/product-experience/BilingualSearchPanel.tsx",
"integration/element-module/src/product-experience/PeopleSurface.tsx",
"integration/element-module/src/product-experience/ProductComposerAccessory.tsx",
"integration/element-module/src/product-experience/ProductExperienceShell.css",
Expand Down
2 changes: 2 additions & 0 deletions tests/layered-ci/v21-product-experience-shell-p0-final-validation.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ test('Product Experience final validation is an exact-head same-repository pull-
assert.doesNotMatch(source, /^\s*(workflow_dispatch|push|schedule):/mu);
assert.match(source, /github\.event\.pull_request\.head\.repo\.full_name\s*==\s*github\.repository/u);
assert.match(source, /github\.event\.pull_request\.head\.ref\s*==\s*'product\/v21-product-experience-shell-p0'/u);
assert.match(source, /github\.event\.pull_request\.head\.ref\s*==\s*'product\/v21-product-experience-bilingual-search-translation-task-ux-p0'/u);
assert.doesNotMatch(source, /github\.event\.pull_request\.head\.ref[\s\S]{0,80}(?:startsWith|contains|matches)/u);
assert.match(source, /runs-on:\s*windows-latest/u);
assert.match(source, /runs-on:\s*ubuntu-latest/u);
assert.match(source, /actions\/checkout@11d5960a326750d5838078e36cf38b85af677262/u);
Expand Down
3 changes: 2 additions & 1 deletion tests/layered-ci/v21-product-experience-shell-p0-routing.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const policy = JSON.parse(fs.readFileSync(path.join(ROOT, 'governance/layered-ci

const V21_PRODUCT_EXPERIENCE_SHELL_P0_BOOTSTRAP_PATHS = Object.freeze([
'config/upstreams/v21-product-experience-shell-p0.json',
'integration/element-module/src/product-experience/BilingualSearchPanel.tsx',
'integration/element-module/src/product-experience/PeopleSurface.tsx',
'integration/element-module/src/product-experience/ProductComposerAccessory.tsx',
'integration/element-module/src/product-experience/ProductExperienceShell.css',
Expand All @@ -35,7 +36,7 @@ const V21_PRODUCT_EXPERIENCE_SHELL_P0_BOOTSTRAP_PATHS = Object.freeze([
]);

test('V2.1 Product Experience Shell P0 bootstrap paths are exact PRODUCT_WP0 routes', () => {
assert.equal(new Set(V21_PRODUCT_EXPERIENCE_SHELL_P0_BOOTSTRAP_PATHS).size, 22);
assert.equal(new Set(V21_PRODUCT_EXPERIENCE_SHELL_P0_BOOTSTRAP_PATHS).size, 23);
for (const file of V21_PRODUCT_EXPERIENCE_SHELL_P0_BOOTSTRAP_PATHS) {
const result = classifyWp0Route(policy, [file]);
assert.equal(result.pass, true, `${file}: ${JSON.stringify(result)}`);
Expand Down
Loading