Skip to content

fix(v21): close bilingual Product final CI routes - #391

Merged
laiqian0239-glitch merged 2 commits into
mainfrom
fix/v21-product-experience-bilingual-search-final-ci-route-closure
Aug 15, 2026
Merged

fix(v21): close bilingual Product final CI routes#391
laiqian0239-glitch merged 2 commits into
mainfrom
fix/v21-product-experience-bilingual-search-final-ci-route-closure

Conversation

@laiqian0239-glitch

Copy link
Copy Markdown
Owner

Implements the exact base-owned prerequisite authorized by #390. First implementation commit 78e31a73e412f4e1d7e67a61a71cb08c835afa4f is tests-only and changes exactly the two existing authorized contracts:

  • tests/layered-ci/v21-product-experience-shell-p0-routing.test.js
  • tests/layered-ci/v21-product-experience-shell-p0-final-validation.test.js

It must causally reproduce both gaps before any policy/workflow change:

  1. BilingualSearchPanel.tsx is not yet an exact PRODUCT_WP0 path.
  2. Product Final Validation does not yet accept the exact bilingual Product branch.

GREEN authority is limited to the existing governance/layered-ci/wp0-routing-policy.json and .github/workflows/v21-product-experience-shell-p0-final-validation.yml, adding only one exact Product path and one exact Product branch literal. No broad prefix/wildcard, trigger expansion, runtime/dependency/Layered risk-policy/UAT evidence changes, validation weakening, alias branch, or new infrastructure is permitted.

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@laiqian0239-glitch, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 40 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b2c404e0-b0f7-487b-8225-a1672f0a9e8e

📥 Commits

Reviewing files that changed from the base of the PR and between 62b3450 and 1cca222.

📒 Files selected for processing (4)
  • .github/workflows/v21-product-experience-shell-p0-final-validation.yml
  • governance/layered-ci/wp0-routing-policy.json
  • tests/layered-ci/v21-product-experience-shell-p0-final-validation.test.js
  • tests/layered-ci/v21-product-experience-shell-p0-routing.test.js

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 40 minutes.

@laiqian0239-glitch laiqian0239-glitch left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent exact-head prerequisite review for 1cca222282bc81e16d8e25417c54bbbfbf810939 under the repository's CodeRabbit-quota fallback rule. CodeRabbit full review did not start because the review limit was reached; no CodeRabbit conclusion is claimed. Verified ancestry: authorization ordinary merge 62b3450a6bc4e2e7ca7cf8ce4cd768f80a101708 -> first implementation commit 78e31a73e412f4e1d7e67a61a71cb08c835afa4f (tests-only, exactly the two authorized existing contracts) -> GREEN descendant 1cca222282bc81e16d8e25417c54bbbfbf810939 (only the two authorized base-owned implementation files). The tests-only run produced exactly the two intended causal failures: missing exact bilingual Product branch in Final Validation and WP0_ROUTE_UNKNOWN_PATH for exactly integration/element-module/src/product-experience/BilingualSearchPanel.tsx; Layered risk selection itself was GREEN. Final net diff from trusted base is exactly four authorized files, ahead 2 / behind 0: workflow +13/-4, WP0 policy +1, Final Validation contract +2, Product route contract +2/-1. Workflow trigger remains pull_request-only; same-repository requirement remains; exact pull_request.head.sha checkout, pinned actions/tools, artifact semantics, clean-tree checks, Windows/Linux materializers, and existing validation steps remain unchanged. The three Product Final jobs now allow exactly two branch literals (product/v21-product-experience-shell-p0 and product/v21-product-experience-bilingual-search-translation-task-ux-p0); no wildcard/prefix/regex/startsWith/contains route was introduced. PRODUCT_BRANCH now binds to the exact github.event.pull_request.head.ref, so the existing candidate/local-branch identity checks continue to fail closed for the selected exact PR head rather than hard-binding the predecessor branch. WP0 routing adds exactly one productExactPaths entry for BilingualSearchPanel.tsx; no Product prefix changed, no existing classification was removed, unknownPathFailsClosed=true, mixed-change escalation, and promotion semantics remain intact. No Product/Electron runtime, dependency, manifest, lockfile, Layered risk-policy, UAT evidence/status, second workflow/UAT framework, trigger expansion, skip/continue-on-error mechanism, temporary alias branch, or new Yance infrastructure is present. Exact-head Stage 6.4.5.9, Layered CI (including Windows/Ubuntu portable), and ACV2 are GREEN; Product Final is correctly skipped on this prerequisite fix/... branch and will be exercised after ordinary merge when fresh main is reconciled into the exact authorized Product branch. Review threads are empty. P0/P1 blocking findings: 0. Merge remains gated on the remaining common exact-head Model Brain Windows sealed-runtime run and a fresh-main check immediately before ordinary merge.

@laiqian0239-glitch
laiqian0239-glitch merged commit 9aecf24 into main Aug 15, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant