Skip to content

chore(FR-2622): add i18n translations for delete-folder option#6883

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-22-chore_fr-2622_add_i18n_translations_for_delete-folder_option
May 7, 2026
Merged

chore(FR-2622): add i18n translations for delete-folder option#6883
graphite-app[bot] merged 1 commit intomainfrom
04-22-chore_fr-2622_add_i18n_translations_for_delete-folder_option

Conversation

@agatha197
Copy link
Copy Markdown
Contributor

@agatha197 agatha197 commented Apr 22, 2026

Resolves #6841 (FR-2622)

Stacked on top of #6881.

Summary

Translates the 5 new adminModelCard.* i18n keys introduced in #6881 into all 20 target languages (de, el, es, fi, fr, id, it, ja, ko, mn, ms, pl, pt-BR, pt, ru, th, tr, vi, zh-CN, zh-TW).

Keys translated:

  • AlsoDeleteModelFolder
  • AlsoDeleteModelFolderTooltip
  • GoToTrash
  • ModelCardAndFolderDeleted
  • ModelCardDeletedFolderKept

Terminology kept consistent with existing translations (e.g., "trash" → 휴지통 / ゴミ箱 / Papierkorb / Poubelle, "model card" → 모델 카드 / モデルカード). Keys inserted at the alphabetically correct position within adminModelCard.

@github-actions github-actions Bot added area:ux UI / UX issue. area:i18n Localization size:L 100~500 LoC labels Apr 22, 2026
Copy link
Copy Markdown
Contributor Author

agatha197 commented Apr 22, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@agatha197 agatha197 marked this pull request as ready for review April 22, 2026 05:52
Copilot AI review requested due to automatic review settings April 22, 2026 05:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds missing localized strings for a “delete associated model folder” option and related delete-to-trash messaging in the Model Card UI across multiple non-English locales.

Changes:

  • Add translations for AlsoDeleteModelFolder and its tooltip describing “moved to trash” behavior.
  • Add a GoToTrash navigation label and new delete-result messages (ModelCardAndFolderDeleted, ModelCardDeletedFolderKept) in each updated locale.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
resources/i18n/zh-TW.json Adds Traditional Chinese translations for the delete-folder option, tooltip, and related delete result messages.
resources/i18n/zh-CN.json Adds Simplified Chinese translations for the delete-folder option, tooltip, and related delete result messages.
resources/i18n/vi.json Adds Vietnamese translations for the delete-folder option, tooltip, and related delete result messages.
resources/i18n/tr.json Adds Turkish translations for the delete-folder option, tooltip, and related delete result messages.
resources/i18n/th.json Adds Thai translations for the delete-folder option, tooltip, and related delete result messages.
resources/i18n/ru.json Adds Russian translations for the delete-folder option, tooltip, and related delete result messages.
resources/i18n/pt.json Adds Portuguese translations for the delete-folder option, tooltip, and related delete result messages.
resources/i18n/pt-BR.json Adds Brazilian Portuguese translations for the delete-folder option, tooltip, and related delete result messages.
resources/i18n/pl.json Adds Polish translations for the delete-folder option, tooltip, and related delete result messages.
resources/i18n/ms.json Adds Malay translations for the delete-folder option, tooltip, and related delete result messages.
resources/i18n/mn.json Adds Mongolian translations for the delete-folder option, tooltip, and related delete result messages.
resources/i18n/ko.json Adds Korean translations for the delete-folder option, tooltip, and related delete result messages.
resources/i18n/ja.json Adds Japanese translations for the delete-folder option, tooltip, and related delete result messages.
resources/i18n/it.json Adds Italian translations for the delete-folder option, tooltip, and related delete result messages.
resources/i18n/id.json Adds Indonesian translations for the delete-folder option, tooltip, and related delete result messages.
resources/i18n/fr.json Adds French translations for the delete-folder option, tooltip, and related delete result messages.
resources/i18n/fi.json Adds Finnish translations for the delete-folder option, tooltip, and related delete result messages.
resources/i18n/es.json Adds Spanish translations for the delete-folder option, tooltip, and related delete result messages.
resources/i18n/el.json Adds Greek translations for the delete-folder option, tooltip, and related delete result messages.
resources/i18n/de.json Adds German translations for the delete-folder option, tooltip, and related delete result messages.

Comment thread resources/i18n/zh-TW.json
@agatha197 agatha197 force-pushed the 04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion branch from 16cba6b to 3885cfa Compare April 22, 2026 05:54
@agatha197 agatha197 force-pushed the 04-22-chore_fr-2622_add_i18n_translations_for_delete-folder_option branch 2 times, most recently from 6775be0 to badb61b Compare April 22, 2026 07:09
@agatha197 agatha197 force-pushed the 04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion branch from 3885cfa to 6e9f608 Compare April 22, 2026 07:09
@agatha197 agatha197 force-pushed the 04-22-chore_fr-2622_add_i18n_translations_for_delete-folder_option branch from badb61b to 99cc2a7 Compare April 22, 2026 07:13
@agatha197 agatha197 force-pushed the 04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion branch 2 times, most recently from 28a3200 to 6ab6683 Compare April 22, 2026 07:15
@agatha197 agatha197 force-pushed the 04-22-chore_fr-2622_add_i18n_translations_for_delete-folder_option branch 2 times, most recently from 67d545a to e490577 Compare April 22, 2026 07:19
@agatha197 agatha197 force-pushed the 04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion branch 2 times, most recently from 5a33b0a to 196618a Compare April 22, 2026 07:21
@agatha197 agatha197 force-pushed the 04-22-chore_fr-2622_add_i18n_translations_for_delete-folder_option branch from e490577 to 6c672c8 Compare April 22, 2026 07:21
Copy link
Copy Markdown
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agatha197 agatha197 force-pushed the 04-22-chore_fr-2622_add_i18n_translations_for_delete-folder_option branch from 6c672c8 to 476ff80 Compare April 23, 2026 11:49
@agatha197 agatha197 force-pushed the 04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion branch 2 times, most recently from 2763cba to 893816e Compare April 24, 2026 05:16
@agatha197 agatha197 force-pushed the 04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion branch from cbde122 to 4fe4032 Compare April 28, 2026 08:00
@agatha197 agatha197 force-pushed the 04-22-chore_fr-2622_add_i18n_translations_for_delete-folder_option branch from 605faec to 8178dc1 Compare April 28, 2026 08:00
@agatha197 agatha197 force-pushed the 04-22-chore_fr-2622_add_i18n_translations_for_delete-folder_option branch from 8178dc1 to c1d1c0a Compare April 30, 2026 04:34
@agatha197 agatha197 force-pushed the 04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion branch from 4fe4032 to 6d6f443 Compare April 30, 2026 04:34
@agatha197 agatha197 force-pushed the 04-22-chore_fr-2622_add_i18n_translations_for_delete-folder_option branch from c1d1c0a to 366b904 Compare April 30, 2026 08:44
@agatha197 agatha197 force-pushed the 04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion branch 2 times, most recently from 19752e5 to 6f30d94 Compare May 4, 2026 23:57
@agatha197 agatha197 force-pushed the 04-22-chore_fr-2622_add_i18n_translations_for_delete-folder_option branch from 366b904 to 500c4be Compare May 4, 2026 23:57
@agatha197 agatha197 force-pushed the 04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion branch from 6f30d94 to aa20978 Compare May 6, 2026 01:45
@agatha197 agatha197 force-pushed the 04-22-chore_fr-2622_add_i18n_translations_for_delete-folder_option branch 2 times, most recently from 01e09f7 to ec76789 Compare May 6, 2026 02:28
@agatha197 agatha197 force-pushed the 04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion branch from aa20978 to 2e8fa5b Compare May 6, 2026 02:28
@agatha197 agatha197 force-pushed the 04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion branch from 2e8fa5b to cf79abc Compare May 6, 2026 10:03
@agatha197 agatha197 force-pushed the 04-22-chore_fr-2622_add_i18n_translations_for_delete-folder_option branch from ec76789 to 1269a59 Compare May 6, 2026 10:03
@agatha197 agatha197 force-pushed the 04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion branch from cf79abc to 6f6bf8c Compare May 7, 2026 04:59
@agatha197 agatha197 force-pushed the 04-22-chore_fr-2622_add_i18n_translations_for_delete-folder_option branch from 1269a59 to 04bb81c Compare May 7, 2026 04:59
@agatha197 agatha197 force-pushed the 04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion branch from 6f6bf8c to 34262a5 Compare May 7, 2026 05:13
@agatha197 agatha197 force-pushed the 04-22-chore_fr-2622_add_i18n_translations_for_delete-folder_option branch from 04bb81c to 6c6c1a1 Compare May 7, 2026 05:13
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 7, 2026

Merge activity

Resolves #6841 (FR-2622)

Stacked on top of #6881.

## Summary

Translates the 5 new `adminModelCard.*` i18n keys introduced in #6881 into all 20 target languages (de, el, es, fi, fr, id, it, ja, ko, mn, ms, pl, pt-BR, pt, ru, th, tr, vi, zh-CN, zh-TW).

Keys translated:
- `AlsoDeleteModelFolder`
- `AlsoDeleteModelFolderTooltip`
- `GoToTrash`
- `ModelCardAndFolderDeleted`
- `ModelCardDeletedFolderKept`

Terminology kept consistent with existing translations (e.g., "trash" → 휴지통 / ゴミ箱 / Papierkorb / Poubelle, "model card" → 모델 카드 / モデルカード). Keys inserted at the alphabetically correct position within `adminModelCard`.
@graphite-app graphite-app Bot force-pushed the 04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion branch from 34262a5 to 6eaccdb Compare May 7, 2026 07:20
@graphite-app graphite-app Bot force-pushed the 04-22-chore_fr-2622_add_i18n_translations_for_delete-folder_option branch from 6c6c1a1 to 8afd5a5 Compare May 7, 2026 07:21
Base automatically changed from 04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion to main May 7, 2026 07:23
@graphite-app graphite-app Bot merged commit 8afd5a5 into main May 7, 2026
4 checks passed
@graphite-app graphite-app Bot deleted the 04-22-chore_fr-2622_add_i18n_translations_for_delete-folder_option branch May 7, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Localization area:ux UI / UX issue. size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to delete model folder alongside model card deletion, with post-deletion notification linking to trash tab

3 participants