Skip to content

test(FR-2652): fix parallel interference and folder-dialog flakiness in delete spec#7162

Closed
agatha197 wants to merge 1 commit into04-28-test_fr-2622_add_e2e_tests_for_bulk_vfolder_trash_on_model_card_bulk_deletionfrom
04-30-test_fr-2652_fix_parallel_interference_and_folder-dialog_flakiness_in_delete_spec
Closed

test(FR-2652): fix parallel interference and folder-dialog flakiness in delete spec#7162
agatha197 wants to merge 1 commit into04-28-test_fr-2622_add_e2e_tests_for_bulk_vfolder_trash_on_model_card_bulk_deletionfrom
04-30-test_fr-2652_fix_parallel_interference_and_folder-dialog_flakiness_in_delete_spec

Conversation

@agatha197
Copy link
Copy Markdown
Contributor

@agatha197 agatha197 commented Apr 30, 2026

Resolves #6885 (FR-2652)

Stacked on top of #7137.

Summary

Fixes flakiness in e2e/admin-model-card/admin-model-card-delete.spec.ts exposed under load:

  • Run delete spec serially. With fullyParallel: true set globally in playwright.config.ts, tests within this file ran in parallel and the server occasionally indexed newly-created cards too slowly to satisfy the name filter (resulting in "No data" assertions). Added test.describe.configure({ mode: 'serial' }) to the describe block so the tests share a deterministic ordering against the same backend.
  • Extend post-cancel row visibility timeout (5s → 15s). After closing the bulk-delete confirmation dialog, the table briefly re-renders. The default 5 s toBeVisible was tight enough to flake when the page was busy.
  • Make createNewFolderViaPlus robust against the Change Project Popconfirm path. The onConfirm handler in AdminModelCardSettingModal runs inside startTransition and silently no-ops when modelStoreProject data isn't loaded yet. The page object now:
    • Increases the Change Project | folder dialog race timeout (5s → 10s).
    • After clicking Change Project, asserts the Current project changed successfully. message — this fails fast (and clearly) when the data dependency isn't ready, instead of timing out later on the folder dialog.
    • Increases the folder-dialog visibility timeout (15s → 30s) for the slow path where the project change actually triggered a refetch.

Test plan

  • pnpm exec playwright test e2e/admin-model-card/admin-model-card-delete.spec.ts — 10/10 passing in ~3.9 minutes
  • Re-run under default fullyParallel: true config — no parallel interference within the file

Copy link
Copy Markdown
Contributor Author

agatha197 commented Apr 30, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the size:L 100~500 LoC label Apr 30, 2026
@agatha197 agatha197 marked this pull request as ready for review April 30, 2026 04:52
@agatha197 agatha197 force-pushed the 04-28-test_fr-2622_add_e2e_tests_for_bulk_vfolder_trash_on_model_card_bulk_deletion branch from fcb679d to e21190c Compare April 30, 2026 08:44
@agatha197 agatha197 force-pushed the 04-30-test_fr-2652_fix_parallel_interference_and_folder-dialog_flakiness_in_delete_spec branch from f25c89e to 0af08bd Compare April 30, 2026 08:44
@agatha197 agatha197 force-pushed the 04-28-test_fr-2622_add_e2e_tests_for_bulk_vfolder_trash_on_model_card_bulk_deletion branch from e21190c to b40dbdf Compare May 4, 2026 23:57
Copilot AI review requested due to automatic review settings May 4, 2026 23:57
@agatha197 agatha197 force-pushed the 04-30-test_fr-2652_fix_parallel_interference_and_folder-dialog_flakiness_in_delete_spec branch from 0af08bd to 318c98a Compare May 4, 2026 23:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR focuses on stabilizing the Admin Model Card delete E2E suite by eliminating parallel interference under fullyParallel: true and tightening a couple of timing/race conditions around bulk delete and folder-creation flows.

Changes:

  • Forces e2e/admin-model-card/admin-model-card-delete.spec.ts to run serially to avoid backend indexing / filter-result races under parallel load.
  • Improves delete-flow robustness by switching header checkbox selection to .click() (handles indeterminate state) and waiting for the Delete button to become enabled before clicking.
  • Hardens folder creation via the “+” path by explicitly asserting the “Current project changed successfully.” toast before waiting for the folder dialog, and extending relevant timeouts.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
e2e/utils/classes/AdminModelCardPage.ts Makes createNewFolderViaPlus resilient to the “Change Project” popconfirm path and slow refetches by asserting the success toast and increasing timeouts.
e2e/admin-model-card/admin-model-card-delete.spec.ts Runs the suite serially and adjusts interaction/wait patterns to reduce flakiness under load (checkbox selection, enabled-state waits, longer visibility timeouts).
e2e/E2E_COVERAGE_REPORT.md Updates the report’s “Last Updated” date.

Comment thread e2e/admin-model-card/admin-model-card-delete.spec.ts Outdated
Comment thread e2e/admin-model-card/admin-model-card-delete.spec.ts Outdated
Comment thread e2e/admin-model-card/admin-model-card-delete.spec.ts Outdated
Comment thread e2e/admin-model-card/admin-model-card-delete.spec.ts Outdated
Comment thread e2e/admin-model-card/admin-model-card-delete.spec.ts
@agatha197 agatha197 force-pushed the 04-28-test_fr-2622_add_e2e_tests_for_bulk_vfolder_trash_on_model_card_bulk_deletion branch from b40dbdf to e2fd11f Compare May 5, 2026 00:21
@agatha197 agatha197 force-pushed the 04-30-test_fr-2652_fix_parallel_interference_and_folder-dialog_flakiness_in_delete_spec branch from 318c98a to 63a727a Compare May 5, 2026 00:21
@agatha197 agatha197 force-pushed the 04-28-test_fr-2622_add_e2e_tests_for_bulk_vfolder_trash_on_model_card_bulk_deletion branch from e2fd11f to 24fdba9 Compare May 5, 2026 00:44
@agatha197 agatha197 force-pushed the 04-30-test_fr-2652_fix_parallel_interference_and_folder-dialog_flakiness_in_delete_spec branch 2 times, most recently from 9a6e1b7 to 2d66c83 Compare May 5, 2026 00:49
@agatha197 agatha197 changed the base branch from 04-28-test_fr-2622_add_e2e_tests_for_bulk_vfolder_trash_on_model_card_bulk_deletion to graphite-base/7162 May 6, 2026 01:45
…in delete spec

- Add test.describe.configure({ mode: 'serial' }) to prevent within-file
  parallelism under fullyParallel:true; filter results were empty under load
  because newly created cards weren't indexed fast enough concurrently
- Extend toBeVisible timeout on post-cancel row assertions (5s → 15s)
- In createNewFolderViaPlus: increase or() timeout (5s → 10s), assert
  "Current project changed successfully." after clicking Change Project so
  the test fails fast if modelStoreProject data isn't loaded yet, and
  increase folder-dialog visibility timeout (15s → 30s)
@agatha197 agatha197 force-pushed the 04-30-test_fr-2652_fix_parallel_interference_and_folder-dialog_flakiness_in_delete_spec branch from 2d66c83 to 28731fa Compare May 6, 2026 01:47
@agatha197 agatha197 force-pushed the graphite-base/7162 branch from 24fdba9 to 3087ee1 Compare May 6, 2026 01:47
@agatha197 agatha197 changed the base branch from graphite-base/7162 to 04-28-test_fr-2622_add_e2e_tests_for_bulk_vfolder_trash_on_model_card_bulk_deletion May 6, 2026 01:47
@agatha197
Copy link
Copy Markdown
Contributor Author

Closing this PR as its changes have been folded into #7137. Both PRs cover E2E test changes for the same spec, so they've been consolidated into one.

@agatha197 agatha197 closed this May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants