-
Notifications
You must be signed in to change notification settings - Fork 78
test(FR-2209): add E2E coverage and finalize i18n for project admin #6658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
yomybaby
wants to merge
1
commit into
graphite-base/6658
from
04-13-test_fr-2209_add_e2e_coverage_and_finalize_i18n
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,240 @@ | ||
| // spec: .specs/FR-2209-project-admin-management/spec.md | ||
| // Stories 1-4 (admin scope + members page) plus ProjectSelect badge. | ||
| // Full validation requires sibling stack PRs (#6652 serving, #6654 vfolder, | ||
| // #6655 sessions, and #6656 header switch confirm) to be merged — tests | ||
| // that exercise features exclusively on those branches are marked with | ||
| // `test.fixme` with an explanatory comment. | ||
| import { | ||
| loginAsCreatedAccount, | ||
| navigateTo, | ||
| webuiEndpoint, | ||
| } from '../utils/test-util'; | ||
| import { test, expect, Page } from '@playwright/test'; | ||
|
|
||
| /** | ||
| * Credentials for the dedicated project-admin test account. | ||
| * | ||
| * Resolved exclusively from env vars (`E2E_PROJECT_ADMIN_EMAIL` and | ||
| * `E2E_PROJECT_ADMIN_PASSWORD`). No hardcoded fallbacks — real test-server | ||
| * credentials must not be committed. When either var is missing, every test | ||
| * in this file is skipped via `test.skip` with an explanatory message. | ||
| * | ||
| * The referenced account must be a project admin of the project named | ||
| * `E2E_PROJECT_ADMIN_PROJECT` (defaults to `default`) on the test cluster. | ||
| */ | ||
| const projectAdminEmail = process.env.E2E_PROJECT_ADMIN_EMAIL; | ||
| const projectAdminPassword = process.env.E2E_PROJECT_ADMIN_PASSWORD; | ||
| const hasProjectAdminCredentials = Boolean( | ||
| projectAdminEmail && projectAdminPassword, | ||
| ); | ||
| const SKIP_REASON = | ||
| 'requires E2E_PROJECT_ADMIN_EMAIL and E2E_PROJECT_ADMIN_PASSWORD env vars'; | ||
|
|
||
| const DEFAULT_PROJECT_NAME = process.env.E2E_PROJECT_ADMIN_PROJECT || 'default'; | ||
|
|
||
| async function loginAsProjectAdmin( | ||
| page: Page, | ||
| request: Parameters<typeof loginAsCreatedAccount>[1], | ||
| ): Promise<void> { | ||
| // `test.skip` at the describe-level guards entry, so by the time this | ||
| // runs both values are defined. The non-null assertions keep the type | ||
| // narrow without re-introducing any fallback literal. | ||
| await loginAsCreatedAccount( | ||
| page, | ||
| request, | ||
| projectAdminEmail!, | ||
| projectAdminPassword!, | ||
| ); | ||
| } | ||
|
Comment on lines
+14
to
+48
|
||
|
|
||
| test.beforeEach(() => { | ||
| // Skip all tests in this file if the project-admin credentials are not | ||
| // supplied via env vars. We intentionally avoid hardcoded fallbacks so | ||
| // real cluster credentials cannot be committed to source control. | ||
| test.skip(!hasProjectAdminCredentials, SKIP_REASON); | ||
| }); | ||
|
|
||
| test.describe( | ||
| 'FR-2209 Project Admin - menu visibility', | ||
| { tag: ['@project-admin', '@rbac', '@functional'] }, | ||
| () => { | ||
| test('project admin can see the Admin category in the sider', async ({ | ||
| page, | ||
| request, | ||
| }) => { | ||
| await loginAsProjectAdmin(page, request); | ||
|
|
||
| // The project-admin tier surfaces a subset of admin pages | ||
| // (Sessions, Serving, Data, Members). Presence of any one of them in | ||
| // the sider is sufficient to confirm the admin category is mounted. | ||
| await expect( | ||
| page.getByRole('menuitem', { name: 'Sessions' }).first(), | ||
| ).toBeVisible(); | ||
| await expect( | ||
| page.getByRole('link', { name: 'Project Members' }), | ||
| ).toBeVisible(); | ||
| }); | ||
| }, | ||
| ); | ||
|
|
||
| test.describe( | ||
| 'FR-2209 Story 1 - admin sessions scope', | ||
| { tag: ['@project-admin', '@rbac', '@functional'] }, | ||
| () => { | ||
| test('project admin can navigate to Admin Sessions page', async ({ | ||
| page, | ||
| request, | ||
| }) => { | ||
| await loginAsProjectAdmin(page, request); | ||
| await navigateTo(page, '/admin-session'); | ||
|
|
||
| // Assert the page rendered (breadcrumb or heading). The exact | ||
| // per-project filter is enforced on the backend side by PR #6655. | ||
| await expect(page).toHaveURL(/\/admin-session/); | ||
| await expect( | ||
| page.getByTestId('webui-breadcrumb').getByText(/Sessions/i), | ||
| ).toBeVisible(); | ||
| }); | ||
|
|
||
| // Requires sibling PR #6655 (FR-2554): backend + UI scope sessions list | ||
| // to the project-admin's project only. Until #6655 merges, the list is | ||
| // unscoped and a content-based assertion would be meaningless. | ||
| test.fixme('admin sessions list only contains the project-admin project (requires #6655)', async () => { | ||
| // Pending: assert every row's project column equals `default`. | ||
| }); | ||
| }, | ||
| ); | ||
|
|
||
| test.describe( | ||
| 'FR-2209 Story 2 - admin serving scope', | ||
| { tag: ['@project-admin', '@rbac', '@functional'] }, | ||
| () => { | ||
| test('project admin can navigate to Admin Serving page', async ({ | ||
| page, | ||
| request, | ||
| }) => { | ||
| await loginAsProjectAdmin(page, request); | ||
| await navigateTo(page, '/admin-serving'); | ||
|
|
||
| await expect(page).toHaveURL(/\/admin-serving/); | ||
| }); | ||
|
|
||
| // The "Start Service" action must be hidden for project-admins in | ||
| // admin-serving. The button is conditionally rendered by PR #6652. | ||
| test.fixme('"Start Service" button is hidden on Admin Serving for project admins (requires #6652)', async () => { | ||
| // Pending: assert getByRole('button', { name: 'Start Service' }) | ||
| // is hidden on /admin-serving for a project-admin session. | ||
| }); | ||
| }, | ||
| ); | ||
|
|
||
| test.describe( | ||
| 'FR-2209 Story 3 - admin vfolder scope', | ||
| { tag: ['@project-admin', '@rbac', '@functional'] }, | ||
| () => { | ||
| test('project admin can navigate to Admin Data page', async ({ | ||
| page, | ||
| request, | ||
| }) => { | ||
| await loginAsProjectAdmin(page, request); | ||
| await navigateTo(page, '/admin-data'); | ||
|
|
||
| await expect(page).toHaveURL(/\/admin-data/); | ||
| }); | ||
|
|
||
| // Create Folder modal should lock the type and project fields for | ||
| // project admins, and only project-scoped folders should appear in | ||
| // the list. That gating lives on PR #6654. | ||
| test.fixme('Create Folder modal locks type and project for project admins (requires #6654)', async () => { | ||
| // Pending: open Create Folder modal and assert type + project | ||
| // fields are disabled and prefilled with the current project. | ||
| }); | ||
| }, | ||
| ); | ||
|
|
||
| test.describe( | ||
| 'FR-2209 Story 4 - project members page', | ||
| { tag: ['@project-admin', '@rbac', '@functional'] }, | ||
| () => { | ||
| test('project admin sees read-only members table with Name/Email/Role columns', async ({ | ||
| page, | ||
| request, | ||
| }) => { | ||
| await loginAsProjectAdmin(page, request); | ||
| await navigateTo(page, '/admin-members'); | ||
|
|
||
| await expect(page).toHaveURL(/\/admin-members/); | ||
|
|
||
| // Card title / page heading | ||
| await expect( | ||
| page.getByText('Project Members', { exact: true }).first(), | ||
| ).toBeVisible(); | ||
|
|
||
| // Table column headers — BAITable surfaces them as | ||
| // `role="columnheader"` on the underlying <th>. | ||
| await expect( | ||
| page.getByRole('columnheader', { name: 'Name', exact: true }), | ||
| ).toBeVisible(); | ||
| await expect( | ||
| page.getByRole('columnheader', { name: 'Email', exact: true }), | ||
| ).toBeVisible(); | ||
| await expect( | ||
| page.getByRole('columnheader', { name: 'Role', exact: true }), | ||
| ).toBeVisible(); | ||
|
|
||
| // Read-only view: there should be no Add Member / Remove Member | ||
| // controls on the page. Project-admins manage members exclusively | ||
| // via the RBAC Management page per the FR-2209 spec. | ||
| await expect( | ||
| page.getByRole('button', { name: /Add Member/i }), | ||
| ).toHaveCount(0); | ||
| await expect( | ||
| page.getByRole('button', { name: /Remove Member/i }), | ||
| ).toHaveCount(0); | ||
| }); | ||
| }, | ||
| ); | ||
|
|
||
| test.describe( | ||
| 'FR-2209 ProjectSelect - Project Admin badge', | ||
| { tag: ['@project-admin', '@rbac', '@functional'] }, | ||
| () => { | ||
| test('"Project Admin" badge appears next to the project in the ProjectSelect dropdown', async ({ | ||
| page, | ||
| request, | ||
| }) => { | ||
| await loginAsProjectAdmin(page, request); | ||
| await page.goto(webuiEndpoint); | ||
|
|
||
| // Open the project selector in the header (rendered as a | ||
| // Select-like button with the current project name). | ||
| const selectorTrigger = page | ||
| .getByRole('combobox') | ||
| .filter({ hasText: DEFAULT_PROJECT_NAME }) | ||
| .first(); | ||
| await expect(selectorTrigger).toBeVisible(); | ||
| await selectorTrigger.click(); | ||
|
|
||
| // Badge is rendered as a Tag inside the option label. | ||
| await expect( | ||
| page.getByText('Project Admin', { exact: true }).first(), | ||
| ).toBeVisible(); | ||
| }); | ||
| }, | ||
| ); | ||
|
|
||
| test.describe( | ||
| 'FR-2209 PR-1b - admin-mode switch confirm', | ||
| { tag: ['@project-admin', '@rbac', '@functional'] }, | ||
| () => { | ||
| // Header-level switch-out-of-admin confirm dialog is introduced in | ||
| // PR #6656 (FR-2553) which is a sibling of this PR's base chain. | ||
| // The i18n keys and logic are not present here yet. | ||
| test.fixme('selecting a non-admin project in admin mode prompts a confirm modal (requires #6656)', async () => { | ||
| // Pending: open header project selector, pick a project where | ||
| // the user is NOT admin, assert confirm modal appears with the | ||
| // SwitchOutOfAdminConfirmTitle/Content copy. Click Cancel and | ||
| // assert the selector restores the previous project. | ||
| }); | ||
| }, | ||
| ); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new E2E spec file is added under
e2e/project-admin/, but the repo’se2e/E2E_COVERAGE_REPORT.mddoes not appear to include the new Project Admin routes/tests. Please update the coverage report (summary row(s), detailed feature tables, and the "Last Updated" date) to reflect the added coverage and any intentionally skipped (test.fixme) scenarios.