test(FR-2209): add E2E coverage and finalize i18n for project admin by yomybaby · Pull Request #6658 · lablup/backend.ai-webui

yomybaby · 2026-04-13T14:30:12Z

Resolves #6650 (FR-2558)

Part of FR-2209 Project Admin Management stack (PR-3 / final).
Stacks on #6657.

Summary

Adds Playwright E2E coverage for all Stories 1–4 plus the admin-mode switch confirm (PR-1b).
Translates new i18n keys added by PR-0..PR-2d into all 19 remaining target languages.
Closes out the FR-2209 epic verification step.

Tests added (`e2e/project-admin/project-admin.spec.ts`)

Executable on this branch:

Project admin can see the Admin category in the sider (after login as project-admin-for-default).
Project admin can navigate to Admin Sessions, Serving, Data, and Members pages.
Project admin sees read-only Members table with Name/Email/Role columns and no Add/Remove buttons.
"Project Admin" badge appears next to the user's project in the ProjectSelect dropdown.

Deferred as test.fixme with an explanatory comment (depend on sibling branches not yet merged to main):

Admin Sessions list is scoped to the project-admin's project — requires feat(FR-2209): add useCurrentUserProjectRoles hook with myRoles RBAC query #6655.
"Start Service" button is hidden on Admin Serving for project admins — requires feat(FR-2209): scope admin serving by project for project admins #6652.
Create Folder modal locks type + project for project admins — requires feat(FR-2209): scope admin vfolders by project and add project-admin folders page #6654.
Admin-mode switch confirm modal appears when selecting a non-admin project — requires feat(FR-2209): control header project selector, confirm admin-mode switch, and fix sider go-back on admin pages #6656.

i18n propagation

Propagated these keys from en.json + ko.json (already added on PR-0..PR-2d) into the remaining 19 language files (de, el, es, fi, fr, id, it, ja, mn, ms, pl, pt-BR, pt, ru, th, tr, vi, zh-CN, zh-TW):

projectMembers.Email, projectMembers.Name, projectMembers.PageTitle, projectMembers.Role, projectMembers.RoleAdmin, projectMembers.RoleMember
projectSelect.ProjectAdminBadge
webui.menu.ProjectMembers

Each file only gained a 12-line insertion block; existing key order, formatting, and whitespace are preserved (string-anchored insertion rather than JSON round-trip, so nothing unrelated was re-sorted).

Note: The header.SwitchOutOfAdminConfirm* keys live on sibling branch #6656 and will be translated there.

Notes

CI full E2E passage expects sibling stack PRs (feat(FR-2209): scope admin serving by project for project admins #6652, feat(FR-2209): scope admin vfolders by project and add project-admin folders page #6654, feat(FR-2209): add useCurrentUserProjectRoles hook with myRoles RBAC query #6655, feat(FR-2209): control header project selector, confirm admin-mode switch, and fix sider go-back on admin pages #6656) to be merged first — some test.fixme assertions target features exclusively on those branches.
Executable E2E tests were run against http://10.122.10.215:8090 with project-admin-for-default@lablup.com. That cluster is currently serving production 26.4.1 without the FR-2209 stack deployed yet, so features under test (admin-members page, admin-mode sider for project-admins, ProjectAdminBadge) are not yet present there — expected failures will resolve once the stack lands. The non-gated tests (admin-serving/admin-data page navigation) passed; the Start/Session/Members/Badge scenarios will pass after deployment.

Verification

bash scripts/verify.sh → === ALL PASS === (Relay, Lint, Format, TypeScript)
Local Playwright run against the FR-2209 test server:
- 2 passed (admin-serving / admin-data page navigation)
- 4 skipped (test.fixme entries waiting on sibling PRs)
- 4 failed on the unseeded server (admin-members page not yet deployed, ProjectAdminBadge code not yet deployed); see Notes above.

yomybaby · 2026-04-13T14:30:32Z

test(FR-2209): add E2E coverage and finalize i18n for project admin #6658 👈 (View in Graphite)
feat(FR-2209): add project members list page for project admins #6657
feat(FR-2525): add project-admin tier to admin menu and project selector #6653 : 1 other dependent PR (#6656 )
feat(FR-2555): add useCurrentUserProjectRoles hook with myRoles RBAC query #6651 : 3 other dependent PRs (#6652 , #6654 , #6655 )
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

Adds missing i18n strings and introduces a new Playwright E2E spec to cover the “Project Admin” experience (menu visibility, navigation to admin-scoped pages, members page, and ProjectSelect badge).

Changes:

Add projectMembers.* and projectSelect.ProjectAdminBadge translations across multiple locales.
Add webui.menu.ProjectMembers translation across multiple locales.
Add e2e/project-admin/project-admin.spec.ts covering core FR-2209 project-admin flows (with several test.fixme placeholders for stacked PR dependencies).

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
resources/i18n/zh-TW.json	Add Traditional Chinese strings for Project Members UI + Project Admin badge + menu entry.
resources/i18n/zh-CN.json	Add Simplified Chinese strings for Project Members UI + Project Admin badge + menu entry.
resources/i18n/vi.json	Add Vietnamese strings for Project Members UI + Project Admin badge + menu entry.
resources/i18n/tr.json	Add Turkish strings for Project Members UI + Project Admin badge + menu entry.
resources/i18n/th.json	Add Thai strings for Project Members UI + Project Admin badge + menu entry.
resources/i18n/ru.json	Add Russian strings for Project Members UI + Project Admin badge + menu entry.
resources/i18n/pt.json	Add Portuguese strings for Project Members UI + Project Admin badge + menu entry.
resources/i18n/pt-BR.json	Add Brazilian Portuguese strings for Project Members UI + Project Admin badge + menu entry.
resources/i18n/pl.json	Add Polish strings for Project Members UI + Project Admin badge + menu entry.
resources/i18n/ms.json	Add Malay strings for Project Members UI + Project Admin badge + menu entry.
resources/i18n/mn.json	Add Mongolian strings for Project Members UI + Project Admin badge + menu entry.
resources/i18n/ja.json	Add Japanese strings for Project Members UI + Project Admin badge + menu entry.
resources/i18n/it.json	Add Italian strings for Project Members UI + Project Admin badge + menu entry.
resources/i18n/id.json	Add Indonesian strings for Project Members UI + Project Admin badge + menu entry.
resources/i18n/fr.json	Add French strings for Project Members UI + Project Admin badge + menu entry.
resources/i18n/fi.json	Add Finnish strings for Project Members UI + Project Admin badge + menu entry.
resources/i18n/es.json	Add Spanish strings for Project Members UI + Project Admin badge + menu entry.
resources/i18n/el.json	Add Greek strings for Project Members UI + Project Admin badge + menu entry.
resources/i18n/de.json	Add German strings for Project Members UI + Project Admin badge + menu entry.
e2e/project-admin/project-admin.spec.ts	New E2E coverage for project-admin menu visibility, key admin routes, members page read-only behavior, and ProjectSelect badge.

Copilot · 2026-04-13T14:36:07Z

+ * Resolved from env (`E2E_PROJECT_ADMIN_EMAIL` / `E2E_PROJECT_ADMIN_PASSWORD`);
+ * falls back to the local `project-admin-for-default@lablup.com` account
+ * documented in the FR-2209 verification notes. That user is the project
+ * admin of the `default` project on the test cluster.
+ */
+const projectAdmin = {
+  email:
+    process.env.E2E_PROJECT_ADMIN_EMAIL ||
+    'project-admin-for-default@lablup.com',
+  password: process.env.E2E_PROJECT_ADMIN_PASSWORD || 'CWR0y4s5E9p#',


The test file hard-codes a non-trivial password fallback. Even for E2E accounts, committing real-looking credentials is a security risk and makes it easy to accidentally reuse in non-test environments. Prefer requiring E2E_PROJECT_ADMIN_PASSWORD (fail fast with a clear error if missing) or using a well-known seeded dev password documented in setup instructions, rather than embedding it in source control.

Suggested change

* Resolved from env (`E2E_PROJECT_ADMIN_EMAIL` / `E2E_PROJECT_ADMIN_PASSWORD`);

* falls back to the local `project-admin-for-default@lablup.com` account

* documented in the FR-2209 verification notes. That user is the project

* admin of the `default` project on the test cluster.

*/

const projectAdmin = {

email:

process.env.E2E_PROJECT_ADMIN_EMAIL ||

'project-admin-for-default@lablup.com',

password: process.env.E2E_PROJECT_ADMIN_PASSWORD || 'CWR0y4s5E9p#',

* The email may fall back to the documented local test account, but the

* password must be provided explicitly via `E2E_PROJECT_ADMIN_PASSWORD` to

* avoid committing reusable credentials to source control.

*/

const projectAdminPassword = process.env.E2E_PROJECT_ADMIN_PASSWORD;

if (!projectAdminPassword) {

throw new Error(

'Missing required environment variable: E2E_PROJECT_ADMIN_PASSWORD',

);

}

const projectAdmin = {

email:

process.env.E2E_PROJECT_ADMIN_EMAIL ||

'project-admin-for-default@lablup.com',

password: projectAdminPassword,

Copilot · 2026-04-13T14:36:08Z

+/**
+ * Credentials for the dedicated project-admin test account.
+ *
+ * Resolved from env (`E2E_PROJECT_ADMIN_EMAIL` / `E2E_PROJECT_ADMIN_PASSWORD`);
+ * falls back to the local `project-admin-for-default@lablup.com` account
+ * documented in the FR-2209 verification notes. That user is the project
+ * admin of the `default` project on the test cluster.
+ */
+const projectAdmin = {
+  email:
+    process.env.E2E_PROJECT_ADMIN_EMAIL ||
+    'project-admin-for-default@lablup.com',
+  password: process.env.E2E_PROJECT_ADMIN_PASSWORD || 'CWR0y4s5E9p#',
+};
+
+const DEFAULT_PROJECT_NAME = 'default';
+
+async function loginAsProjectAdmin(
+  page: Page,
+  request: Parameters<typeof loginAsCreatedAccount>[1],
+): Promise<void> {
+  await loginAsCreatedAccount(
+    page,
+    request,
+    projectAdmin.email,
+    projectAdmin.password,
+  );
+}


This introduces new project-admin-specific credentials/env vars (E2E_PROJECT_ADMIN_EMAIL/E2E_PROJECT_ADMIN_PASSWORD) but they aren’t centralized alongside the other E2E accounts in e2e/utils/test-util.ts (userInfo) or documented in the E2E setup docs. Consider adding a userInfo.projectAdmin entry and documenting the required env vars so contributors/CI can run these tests consistently.

Copilot · 2026-04-13T14:36:08Z

+// spec: .specs/FR-2209-project-admin-management/spec.md
+// Stories 1-4 (admin scope + members page) plus ProjectSelect badge.
+// Full validation requires sibling stack PRs (#6652 serving, #6654 vfolder,
+// #6655 sessions, and #6656 header switch confirm) to be merged — tests
+// that exercise features exclusively on those branches are marked with
+// `test.fixme` with an explanatory comment.


A new E2E spec file is added under e2e/project-admin/, but the repo’s e2e/E2E_COVERAGE_REPORT.md does not appear to include the new Project Admin routes/tests. Please update the coverage report (summary row(s), detailed feature tables, and the "Last Updated" date) to reflect the added coverage and any intentionally skipped (test.fixme) scenarios.

Copilot AI review requested due to automatic review settings April 13, 2026 14:30

github-actions Bot assigned yomybaby Apr 13, 2026

github-actions Bot added area:ux UI / UX issue. area:i18n Localization size:L 100~500 LoC labels Apr 13, 2026

yomybaby mentioned this pull request Apr 13, 2026

feat(FR-2209): add project members list page for project admins #6657

Merged

4 tasks

Copilot started reviewing on behalf of yomybaby April 13, 2026 14:31 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

yomybaby changed the base branch from 04-13-feat_fr-2209_add_project_members_list_page_for_project_admins to graphite-base/6658 April 13, 2026 14:49

test(FR-2209): add e2e coverage and finalize i18n

1308a03

yomybaby force-pushed the graphite-base/6658 branch from 09f6dd1 to abdce81 Compare April 13, 2026 14:49

yomybaby force-pushed the 04-13-test_fr-2209_add_e2e_coverage_and_finalize_i18n branch from 3304519 to 1308a03 Compare April 13, 2026 14:49

yomybaby changed the base branch from graphite-base/6658 to 04-13-feat_fr-2209_add_project_members_list_page_for_project_admins April 13, 2026 14:49

yomybaby changed the base branch from 04-13-feat_fr-2209_add_project_members_list_page_for_project_admins to graphite-base/6658 April 14, 2026 04:18

yomybaby closed this Apr 14, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(FR-2209): add E2E coverage and finalize i18n for project admin#6658

test(FR-2209): add E2E coverage and finalize i18n for project admin#6658
yomybaby wants to merge 1 commit intographite-base/6658from
04-13-test_fr-2209_add_e2e_coverage_and_finalize_i18n

yomybaby commented Apr 13, 2026 •

edited

Loading

Uh oh!

yomybaby commented Apr 13, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 13, 2026

Uh oh!

Copilot AI Apr 13, 2026

Uh oh!

Copilot AI Apr 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

yomybaby commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Tests added (e2e/project-admin/project-admin.spec.ts)

i18n propagation

Notes

Verification

Uh oh!

yomybaby commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

yomybaby commented Apr 13, 2026 •

edited

Loading

Tests added (`e2e/project-admin/project-admin.spec.ts`)

yomybaby commented Apr 13, 2026 •

edited

Loading