This repository was archived by the owner on Oct 10, 2025. It is now read-only.
vector extension optional params + features#5955
Merged
Conversation
Contributor
Author
|
General changes and worries:
|
ray6080
reviewed
Sep 3, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5955 +/- ##
=======================================
Coverage 85.76% 85.76%
=======================================
Files 1641 1641
Lines 75467 75525 +58
Branches 8985 9003 +18
=======================================
+ Hits 64721 64777 +56
- Misses 10488 10490 +2
Partials 258 258
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark ResultMaster commit hash:
Other queries
|
sdht0
reviewed
Sep 3, 2025
sdht0
reviewed
Sep 3, 2025
1 task
ray6080
suggested changes
Sep 3, 2025
Contributor
Author
|
New solution checks if |
…tableName) with basic test
Contributor
Author
|
Above comment resolved, should be good to go |
acquamarin
suggested changes
Sep 4, 2025
| @@ -0,0 +1,87 @@ | |||
| #include "catalog/catalog.h" | |||
Contributor
There was a problem hiding this comment.
I don't think we need such function right now. @ray6080 can comment there as well.
Contributor
There was a problem hiding this comment.
Fine either ways, just saw a usecase here: https://github.com/getzep/graphiti/blob/c0fcc82ebef01dadde12d669dfe3beadfa238a1e/graphiti_core/utils/maintenance/graph_data_operations.py#L40
acquamarin
reviewed
Sep 5, 2025
acquamarin
approved these changes
Sep 8, 2025
ray6080
approved these changes
Sep 8, 2025
| const auto nodeTableEntry = HNSWIndexUtils::bindNodeTable(*context, tableName); | ||
| if (HNSWIndexUtils::validateIndexExistence(*context, nodeTableEntry, indexName, | ||
| HNSWIndexUtils::IndexOperation::CREATE, config.conflictAction)) { | ||
| return std::make_unique<CreateHNSWIndexBindData>(context, indexName, nullptr, 0, 0, |
Contributor
There was a problem hiding this comment.
We inline comments as follows:
Suggested change
| return std::make_unique<CreateHNSWIndexBindData>(context, indexName, nullptr, 0, 0, | |
| return std::make_unique<CreateHNSWIndexBindData>(context, indexName, nullptr /*nodeTableEntry*/, 0 /*propertyID*/, 0 /*numNodes*/, |
| catalog::TableCatalogEntry* tableEntry; | ||
| common::property_id_t propertyID; | ||
| HNSWIndexConfig config; | ||
| bool skipAfterBind; |
Contributor
There was a problem hiding this comment.
I would rename this to skipIndexCreation, which is more accurate.
| struct DropHNSWIndexBindData final : TableFuncBindData { | ||
| catalog::NodeTableCatalogEntry* tableEntry; | ||
| std::string indexName; | ||
| bool skipAfterBind; |
Contributor
There was a problem hiding this comment.
Rename to something along the line of skipIndexDropping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
skip_if_existsoptional param forCREATE_VECTOR_INDEXcypher functionskip_if_not_existsoptional param forDROP_VECTOR_INDEXcypher functionerror_suppress.testBasic test of above indittodrop_all.testFixes #5808
Associated docs (issue or PR):
#5808
#5755 (not too sure whether I should cover this as well)
Contributor agreement