Skip to content
This repository was archived by the owner on Oct 10, 2025. It is now read-only.

Add test_list in root dir to .gitignore#5957

Merged
carminite merged 2 commits intomasterfrom
origin/gitignore-root-test-list
Sep 3, 2025
Merged

Add test_list in root dir to .gitignore#5957
carminite merged 2 commits intomasterfrom
origin/gitignore-root-test-list

Conversation

@carminite
Copy link
Copy Markdown
Contributor

@carminite carminite commented Sep 3, 2025

Description

Solely in response to #5955 (comment)

The testing framework example outlined in https://docs.kuzudb.com/developer-guide/testing-framework/#running-a-specific-group-or-test-case has the user generate a test_list file in their current directory (likely the repo root directory). Might as well spare me them the grief of accidental change commits and .gitignore it beforehand.

Contributor agreement

@carminite carminite changed the title Add test_list in root dir Add test_list in root dir to .gitignore Sep 3, 2025
Copy link
Copy Markdown
Contributor

@sdht0 sdht0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes wanted this as well, thanks.

Comment thread .gitignore Outdated
@@ -8,6 +8,7 @@ bazel-*
.bazelrc
**/test/test_files/test_list
extension/test_list
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably remove line 9 and 10 then. Can you verify and remove them.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Seems good

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.75%. Comparing base (d764eaf) to head (7a855b1).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5957   +/-   ##
=======================================
  Coverage   85.75%   85.75%           
=======================================
  Files        1639     1639           
  Lines       75357    75357           
  Branches     8972     8972           
=======================================
  Hits        64623    64623           
  Misses      10476    10476           
  Partials      258      258           
Flag Coverage Δ
extension 63.82% <ø> (-0.01%) ⬇️
in-mem 80.95% <ø> (-0.02%) ⬇️
on-disk 86.33% <ø> (+<0.01%) ⬆️
recovery 86.32% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@carminite carminite merged commit 4158bbb into master Sep 3, 2025
13 checks passed
@carminite carminite deleted the origin/gitignore-root-test-list branch September 3, 2025 18:34
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 3, 2025

Benchmark Result

Master commit hash: bbb02f384ab5730a73925173e34a08c46aa23d59
Branch commit hash: 7933ceaaa3bf5c59ac6e0842c63865ad1763221a

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
ldbc_snb_is q32 4.04 5.57 -1.53 (-27.47%)
recursive_join recursive-join-dense 5310.42 6994.88 -1684.46 (-24.08%)
Other queries
Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 699.84 698.45 1.40 (0.20%)
aggregation q28 7649.42 7694.44 -45.02 (-0.59%)
filter q14 60.22 61.46 -1.23 (-2.00%)
filter q15 60.51 58.20 2.31 (3.97%)
filter q16 272.43 276.47 -4.04 (-1.46%)
filter q17 380.65 380.02 0.63 (0.17%)
filter q18 1892.63 1838.55 54.09 (2.94%)
filter zonemap-node 23.48 23.80 -0.31 (-1.31%)
filter zonemap-node-lhs-cast 23.67 23.96 -0.29 (-1.21%)
filter zonemap-node-null 23.50 23.56 -0.07 (-0.29%)
filter zonemap-rel 5652.44 5570.53 81.91 (1.47%)
fixed_size_expr_evaluator q07 617.42 619.17 -1.75 (-0.28%)
fixed_size_expr_evaluator q08 902.28 901.94 0.34 (0.04%)
fixed_size_expr_evaluator q09 905.21 907.44 -2.23 (-0.25%)
fixed_size_expr_evaluator q10 190.28 190.54 -0.26 (-0.14%)
fixed_size_expr_evaluator q11 189.93 190.38 -0.45 (-0.23%)
fixed_size_expr_evaluator q12 168.89 167.60 1.29 (0.77%)
fixed_size_expr_evaluator q13 1488.12 1496.40 -8.29 (-0.55%)
fixed_size_seq_scan q23 44.40 44.95 -0.55 (-1.22%)
join q29 805.23 765.96 39.26 (5.13%)
join q30 1839.89 1699.83 140.06 (8.24%)
join q31 5.72 5.86 -0.14 (-2.44%)
join SelectiveTwoHopJoin 45.77 51.30 -5.53 (-10.78%)
ldbc_snb_ic q35 8.98 10.13 -1.15 (-11.35%)
ldbc_snb_ic q36 96.74 106.35 -9.61 (-9.04%)
ldbc_snb_is q33 14.26 14.73 -0.47 (-3.19%)
ldbc_snb_is q34 1.16 1.30 -0.14 (-10.74%)
limit push-down-limit-into-distinct 1894.45 1951.19 -56.74 (-2.91%)
multi-rel multi-rel-large-scan 1471.76 1500.42 -28.66 (-1.91%)
multi-rel multi-rel-lookup 8.73 10.48 -1.75 (-16.67%)
multi-rel multi-rel-small-scan 171.23 201.24 -30.02 (-14.92%)
order_by q25 62.11 62.98 -0.88 (-1.39%)
order_by q26 375.67 385.70 -10.03 (-2.60%)
order_by q27 1304.75 1291.11 13.65 (1.06%)
recursive_join recursive-join-bidirection 291.38 301.13 -9.75 (-3.24%)
recursive_join recursive-join-path 22265.93 23080.94 -815.01 (-3.53%)
recursive_join recursive-join-sparse 9.30 8.70 0.60 (6.91%)
recursive_join recursive-join-trail 5648.64 6954.70 -1306.06 (-18.78%)
scan_after_filter q01 104.69 102.20 2.49 (2.44%)
scan_after_filter q02 89.84 90.64 -0.80 (-0.88%)
shortest_path_ldbc100 q37 68.58 77.60 -9.01 (-11.62%)
shortest_path_ldbc100 q38 349.34 355.19 -5.86 (-1.65%)
shortest_path_ldbc100 q39 86.08 85.61 0.47 (0.55%)
shortest_path_ldbc100 q40 520.99 498.31 22.68 (4.55%)
var_size_expr_evaluator q03 2097.47 2089.42 8.06 (0.39%)
var_size_expr_evaluator q04 2199.64 2133.35 66.29 (3.11%)
var_size_expr_evaluator q05 2597.90 2511.95 85.95 (3.42%)
var_size_expr_evaluator q06 1313.24 1290.69 22.55 (1.75%)
var_size_seq_scan q19 1349.47 1342.59 6.88 (0.51%)
var_size_seq_scan q20 2700.62 2672.07 28.55 (1.07%)
var_size_seq_scan q21 2173.04 2162.37 10.66 (0.49%)
var_size_seq_scan q22 106.91 107.31 -0.40 (-0.37%)

Jasonlmx pushed a commit that referenced this pull request Sep 4, 2025
* Consolidated all test_list search fields to `**/test_list` in .gitignore for dev convenience
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants