-
Notifications
You must be signed in to change notification settings - Fork 4
bump github.com/apache/pulsar-client-go v0.16.0 #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matthyx
wants to merge
2
commits into
main
Choose a base branch
from
bump
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
testcontainers-go k3s module v0.35.0 compatibility💡 Result:
In testcontainers-go v0.35.0, the K3s module is supported and ships in-repo (it has existed since v0.21.0) and you use it by importing
github.com/testcontainers/testcontainers-go/modules/k3sand starting it viak3s.Run(...)(theRunentrypoint is documented as available since v0.32.0). [1][2]K3s image compatibility: the module is designed to run whatever
rancher/k3s:<tag>image you pass in (the docs show examples likerancher/k3s:v1.27.1-k3s1). [1][3]Environment compatibility constraints (common “it doesn’t work” cases): K3s runs as a privileged container and needs to be able to spawn containers, so it may not work in rootless Docker, Docker-in-Docker, or other environments where privileged containers are disallowed. [4]
v0.35.0-specific note: v0.35.0 introduced core breaking changes (not K3s-specific), notably
container.Terminate(ctx)gaining variadic termination options and a change fromShouldPrintBuildLogtoBuildLogWriterfor Dockerfile builds—these can affect compilation if your test harness uses those APIs. [2]Sources:
[1] https://golang.testcontainers.org/modules/k3s/
[2] https://github.com/testcontainers/testcontainers-go/releases/tag/v0.35.0
[3] https://testcontainers.com/modules/k3s/
[4] https://java.testcontainers.org/modules/k3s/
🌐 Web query:
testcontainers-go/modules/k3s version release history💡 Result:
testcontainers-go/modules/k3s(Go) – version/release history (highlights)Module-level milestones are tracked as part of the main
github.com/testcontainers/testcontainers-gorelease versions:GetKubeConfigavailable. [2](*K3sContainer).LoadImages(...)added. [1], [2]WithManifest(manifestPath)option added. [1], [2]Run(ctx, img, ...)entrypoint added (andRunContainerlater marked deprecated). [1], [2](*K3sContainer).LoadImagesWithOpts(...)added. [1]#3413). [3]Sources: pkg.go.dev API “added in vX.Y.Z” annotations for
modules/k3s[1], Testcontainers-Go K3s module docs [2], andtestcontainers-goGitHub releases page (latest + v0.40.0 notes) [3].🌐 Web query:
testcontainers-go v0.35.0 k3s module version requirements💡 Result:
For testcontainers-go v0.35.0, the K3s module is a separate Go module you depend on as:
github.com/testcontainers/testcontainers-go/modules/k3s@v0.35.0(published Jan 10, 2025) [1][2]In practice, that means:
modules/k3sto v0.35.0 will also pull in the matching testcontainers-go v0.35.0 dependency (because the module lives in the same repo/version line) [2].k8s.io/client-go,k8s.io/api,k8s.io/apimachinery) as shown by the module’s documented usage/imports [3].I wasn’t able to fetch the exact
modules/k3sv0.35.0go.modcontents (to list the precise Go version / exact dependency version pins) from the available sources here, because thego.modlink resolves to GitHub content that failed to load in this environment [2]. If you paste thego.mod(or tell me yourgo env GOPROXY), I can extract the exact version requirements precisely.Sources: [1] [2] [3]
Align K3s module version to match core v0.35.0.
The K3s module is pinned to v0.33.0 while the core is at v0.35.0. Since both are part of the same testcontainers-go repository and versioned together, they should match. The v0.35.0 release introduced breaking changes to the core API (
Terminatesignature andShouldPrintBuildLog→BuildLogWriter), which the v0.33.0 K3s module may not account for. Update modules/k3s to v0.35.0 to ensure compatibility.Fix
📝 Committable suggestion
🤖 Prompt for AI Agents