bump github.com/apache/pulsar-client-go v0.16.0 #120
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -3,7 +3,7 @@ module github.com/kubescape/synchronizer | |||||||||||||||||||||||
| go 1.25.6 | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| require ( | ||||||||||||||||||||||||
| github.com/apache/pulsar-client-go v0.16.0 | ||||||||||||||||||||||||
| github.com/armosec/armoapi-go v0.0.596 | ||||||||||||||||||||||||
| github.com/armosec/utils-k8s-go v0.0.30 | ||||||||||||||||||||||||
| github.com/cenkalti/backoff/v4 v4.3.0 | ||||||||||||||||||||||||
|
|
@@ -24,7 +24,7 @@ require ( | |||||||||||||||||||||||
| github.com/robfig/cron/v3 v3.0.1 | ||||||||||||||||||||||||
| github.com/spf13/viper v1.20.1 | ||||||||||||||||||||||||
| github.com/stretchr/testify v1.11.0 | ||||||||||||||||||||||||
| github.com/testcontainers/testcontainers-go v0.35.0 | ||||||||||||||||||||||||
| github.com/testcontainers/testcontainers-go/modules/k3s v0.33.0 | ||||||||||||||||||||||||
|
Comment on lines
+27
to
28
There was a problem hiding this comment. 🧩 Analysis chain🌐 Web query:
💡 Result: In testcontainers-go v0.35.0, the K3s module is supported and ships in-repo (it has existed since v0.21.0) and you use it by importing K3s image compatibility: the module is designed to run whatever Environment compatibility constraints (common “it doesn’t work” cases): K3s runs as a privileged container and needs to be able to spawn containers, so it may not work in rootless Docker, Docker-in-Docker, or other environments where privileged containers are disallowed. [4] v0.35.0-specific note: v0.35.0 introduced core breaking changes (not K3s-specific), notably Sources: 🌐 Web query:
💡 Result:
|
||||||||||||||||||||||||
| Testcontainers-Go version | K3s module change |
|---|---|
| v0.21.0 | K3s module exists (“Since v0.21.0”); GetKubeConfig available. [2] |
| v0.25.0 | (*K3sContainer).LoadImages(...) added. [1], [2] |
| v0.29.0 | WithManifest(manifestPath) option added. [1], [2] |
| v0.32.0 | Run(ctx, img, ...) entrypoint added (and RunContainer later marked deprecated). [1], [2] |
| v0.39.0 | (*K3sContainer).LoadImagesWithOpts(...) added. [1] |
| v0.40.0 (latest shown on GitHub releases page, Nov 6, 2025) | Repo-wide module migration work includes “k3s: use Run function” (PR #3413). [3] |
Sources: pkg.go.dev API “added in vX.Y.Z” annotations for modules/k3s [1], Testcontainers-Go K3s module docs [2], and testcontainers-go GitHub releases page (latest + v0.40.0 notes) [3].
🌐 Web query:
testcontainers-go v0.35.0 k3s module version requirements
💡 Result:
For testcontainers-go v0.35.0, the K3s module is a separate Go module you depend on as:
github.com/testcontainers/testcontainers-go/modules/k3s@v0.35.0(published Jan 10, 2025) [1][2]
In practice, that means:
- Pinning
modules/k3sto v0.35.0 will also pull in the matching testcontainers-go v0.35.0 dependency (because the module lives in the same repo/version line) [2]. - Your project will also need Kubernetes client libraries (e.g.,
k8s.io/client-go,k8s.io/api,k8s.io/apimachinery) as shown by the module’s documented usage/imports [3].
I wasn’t able to fetch the exact modules/k3s v0.35.0 go.mod contents (to list the precise Go version / exact dependency version pins) from the available sources here, because the go.mod link resolves to GitHub content that failed to load in this environment [2]. If you paste the go.mod (or tell me your go env GOPROXY), I can extract the exact version requirements precisely.
Sources: [1] [2] [3]
Align K3s module version to match core v0.35.0.
The K3s module is pinned to v0.33.0 while the core is at v0.35.0. Since both are part of the same testcontainers-go repository and versioned together, they should match. The v0.35.0 release introduced breaking changes to the core API (Terminate signature and ShouldPrintBuildLog → BuildLogWriter), which the v0.33.0 K3s module may not account for. Update modules/k3s to v0.35.0 to ensure compatibility.
Fix
- github.com/testcontainers/testcontainers-go/modules/k3s v0.33.0
+ github.com/testcontainers/testcontainers-go/modules/k3s v0.35.0📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| github.com/testcontainers/testcontainers-go v0.35.0 | |
| github.com/testcontainers/testcontainers-go/modules/k3s v0.33.0 | |
| github.com/testcontainers/testcontainers-go v0.35.0 | |
| github.com/testcontainers/testcontainers-go/modules/k3s v0.35.0 |
🤖 Prompt for AI Agents
In `@go.mod` around lines 27 - 28, Update the testcontainers k3s module version to
match the core package: change the dependency for
"github.com/testcontainers/testcontainers-go/modules/k3s" from v0.33.0 to
v0.35.0 so it aligns with "github.com/testcontainers/testcontainers-go v0.35.0";
this ensures the k3s module is compatible with the core API changes (e.g.,
Terminate signature and BuildLogWriter) and avoids version mismatch issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amirmalka can you check if that makes sense?