Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deployment/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ spec:
containers:
- name: kruize-optimizer
# TODO: This image will be updated with kruize org image
image: quay.io/kruize/kruize-optimizer:0.0.1
image: quay.io/kruize/kruize-optimizer:0.0.2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High · Optimizer image cannot be pulled

When the documented build flow is used without separately publishing tag 0.0.2 at quay.io/kruize/kruize-optimizer, kubernetes cannot pull the image requested by the deployment: the documented build publishes to quay.io/kruize/optimizer, while CI checks quay.io/kruizehub/optimizer without pushing. The pod stays unavailable and the updated version is not deployed.

Make the deployment image reference match the image that the build and publish flow pushes, or publish the image to the deployment’s repository.

Prompt for AI agents
In `deployment/base/deployment.yaml` at line 21:

**Optimizer image cannot be pulled**

When the documented build flow is used without separately publishing tag `0.0.2` at `quay.io/kruize/kruize-optimizer`, kubernetes cannot pull the image requested by the deployment: the documented build publishes to `quay.io/kruize/optimizer`, while CI checks `quay.io/kruizehub/optimizer` without pushing. The pod stays unavailable and the updated version is not deployed.

Make the deployment image reference match the image that the build and publish flow pushes, or publish the image to the deployment’s repository.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium · Rollout duplicates scheduled jobs

When an enabled bulk config exists while Kubernetes rolls out the updated image, the old and new pods each initialize timers for the same enabled configs and submit the same bulk jobs to Kruize, so a version rollout can create duplicate experiments.

Ensure only one pod schedules jobs at a time, for example with leader election or a rollout strategy that stops the old pod before starting the new one.

Prompt for AI agents
In `deployment/base/deployment.yaml` at line 21:

**Rollout duplicates scheduled jobs**

When an enabled bulk config exists while Kubernetes rolls out the updated image, the old and new pods each initialize timers for the same enabled configs and submit the same bulk jobs to Kruize, so a version rollout can create duplicate experiments.

Ensure only one pod schedules jobs at a time, for example with leader election or a rollout strategy that stops the old pod before starting the new one.

imagePullPolicy: Always
ports:
- containerPort: 8080
Expand Down
Loading