Repository navigation
Update version in deployment #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mvp_demo
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ spec: | |
| containers: | ||
| - name: kruize-optimizer | ||
| # TODO: This image will be updated with kruize org image | ||
| image: quay.io/kruize/kruize-optimizer:0.0.1 | ||
| image: quay.io/kruize/kruize-optimizer:0.0.2 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Medium · Rollout duplicates scheduled jobs When an enabled bulk config exists while Kubernetes rolls out the updated image, the old and new pods each initialize timers for the same enabled configs and submit the same bulk jobs to Kruize, so a version rollout can create duplicate experiments. Ensure only one pod schedules jobs at a time, for example with leader election or a rollout strategy that stops the old pod before starting the new one. Prompt for AI agentsIn `deployment/base/deployment.yaml` at line 21:
**Rollout duplicates scheduled jobs**
When an enabled bulk config exists while Kubernetes rolls out the updated image, the old and new pods each initialize timers for the same enabled configs and submit the same bulk jobs to Kruize, so a version rollout can create duplicate experiments.
Ensure only one pod schedules jobs at a time, for example with leader election or a rollout strategy that stops the old pod before starting the new one. |
||
| imagePullPolicy: Always | ||
| ports: | ||
| - containerPort: 8080 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 High · Optimizer image cannot be pulled
When the documented build flow is used without separately publishing tag
0.0.2atquay.io/kruize/kruize-optimizer, kubernetes cannot pull the image requested by the deployment: the documented build publishes toquay.io/kruize/optimizer, while CI checksquay.io/kruizehub/optimizerwithout pushing. The pod stays unavailable and the updated version is not deployed.Make the deployment image reference match the image that the build and publish flow pushes, or publish the image to the deployment’s repository.
Prompt for AI agents