Repository navigation
Update version in deployment - #57
kusumachalasani wants to merge 1 commit into
Conversation
Signed-off-by: kusuma chalasani <kchalasani@ibm.com>
Reviewer's GuideConfigurationUpdate the deployed kruize-optimizer image from version 0.0.1 to 0.0.2.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="deployment/base/deployment.yaml" line_range="21" />
<code_context>
- name: kruize-optimizer
# TODO: This image will be updated with kruize org image
- image: quay.io/kruize/kruize-optimizer:0.0.1
+ image: quay.io/kruize/kruize-optimizer:0.0.2
imagePullPolicy: Always
ports:
</code_context>
<issue_to_address>
**Optimizer image cannot be pulled**
When the documented build flow is used without separately publishing tag `0.0.2` at `quay.io/kruize/kruize-optimizer`, kubernetes cannot pull the image requested by the deployment: the documented build publishes to `quay.io/kruize/optimizer`, while CI checks `quay.io/kruizehub/optimizer` without pushing. The pod stays unavailable and the updated version is not deployed.
Make the deployment image reference match the image that the build and publish flow pushes, or publish the image to the deployment’s repository.
</issue_to_address>
### Comment 2
<location path="deployment/base/deployment.yaml" line_range="21" />
<code_context>
- name: kruize-optimizer
# TODO: This image will be updated with kruize org image
- image: quay.io/kruize/kruize-optimizer:0.0.1
+ image: quay.io/kruize/kruize-optimizer:0.0.2
imagePullPolicy: Always
ports:
</code_context>
<issue_to_address>
**Rollout duplicates scheduled jobs**
When an enabled bulk config exists while Kubernetes rolls out the updated image, the old and new pods each initialize timers for the same enabled configs and submit the same bulk jobs to Kruize, so a version rollout can create duplicate experiments.
Ensure only one pod schedules jobs at a time, for example with leader election or a rollout strategy that stops the old pod before starting the new one.
</issue_to_address>Sourcery assessment
Approval pending. 2 findings to address first.
Blocking findings: deployment/base/deployment.yaml:21, deployment/base/deployment.yaml:21
| - name: kruize-optimizer | ||
| # TODO: This image will be updated with kruize org image | ||
| image: quay.io/kruize/kruize-optimizer:0.0.1 | ||
| image: quay.io/kruize/kruize-optimizer:0.0.2 |
There was a problem hiding this comment.
🟠 High · Optimizer image cannot be pulled
When the documented build flow is used without separately publishing tag 0.0.2 at quay.io/kruize/kruize-optimizer, kubernetes cannot pull the image requested by the deployment: the documented build publishes to quay.io/kruize/optimizer, while CI checks quay.io/kruizehub/optimizer without pushing. The pod stays unavailable and the updated version is not deployed.
Make the deployment image reference match the image that the build and publish flow pushes, or publish the image to the deployment’s repository.
Prompt for AI agents
In `deployment/base/deployment.yaml` at line 21:
**Optimizer image cannot be pulled**
When the documented build flow is used without separately publishing tag `0.0.2` at `quay.io/kruize/kruize-optimizer`, kubernetes cannot pull the image requested by the deployment: the documented build publishes to `quay.io/kruize/optimizer`, while CI checks `quay.io/kruizehub/optimizer` without pushing. The pod stays unavailable and the updated version is not deployed.
Make the deployment image reference match the image that the build and publish flow pushes, or publish the image to the deployment’s repository.| - name: kruize-optimizer | ||
| # TODO: This image will be updated with kruize org image | ||
| image: quay.io/kruize/kruize-optimizer:0.0.1 | ||
| image: quay.io/kruize/kruize-optimizer:0.0.2 |
There was a problem hiding this comment.
🟡 Medium · Rollout duplicates scheduled jobs
When an enabled bulk config exists while Kubernetes rolls out the updated image, the old and new pods each initialize timers for the same enabled configs and submit the same bulk jobs to Kruize, so a version rollout can create duplicate experiments.
Ensure only one pod schedules jobs at a time, for example with leader election or a rollout strategy that stops the old pod before starting the new one.
Prompt for AI agents
In `deployment/base/deployment.yaml` at line 21:
**Rollout duplicates scheduled jobs**
When an enabled bulk config exists while Kubernetes rolls out the updated image, the old and new pods each initialize timers for the same enabled configs and submit the same bulk jobs to Kruize, so a version rollout can create duplicate experiments.
Ensure only one pod schedules jobs at a time, for example with leader election or a rollout strategy that stops the old pod before starting the new one.
Summary by Sourcery
Deployment: