Skip to content

Fix generate_linux_binary.sh spec path and image tag #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaixxx merged 1 commit into from
Oct 25, 2026
+10 −4
Merged

Fix generate_linux_binary.sh spec path and image tag #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docker/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,8 @@ still passes.

The `Dockerfile` in the repository root is unrelated to this image. It is the
build environment that `generate_linux_binary.sh` uses for the PyInstaller
binary. That script also tags its image `noscribe`, so running it replaces the
image built here; rebuild afterwards or use a different tag for one of them.
binary and tags its image `noscribe-pyinstaller`, so it does not replace the
image built here.

## Files

Expand Down
10 changes: 8 additions & 2 deletions generate_linux_binary.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
#!/bin/bash
set -euo pipefail

docker buildx build --platform linux/amd64 -t noscribe .
docker run --rm -it --mount type=bind,src=.,dst=/usr/src/app noscribe pyinstaller noScribe-linux.spec
# Builds the Linux binary with PyInstaller inside the build environment from the
# root Dockerfile. The image gets its own tag so it does not replace the
# noScribe image from docker/ (tagged noscribe).
IMAGE=noscribe-pyinstaller

docker buildx build --platform linux/amd64 -t "$IMAGE" --load .
docker run --rm -it --mount type=bind,src=.,dst=/usr/src/app "$IMAGE" pyinstaller pyinstaller/noScribe_linux.spec
Loading