Repository navigation
Fix generate_linux_binary.sh spec path and image tag - #375
Merged
Merged
Conversation
The script called noScribe-linux.spec, which no longer exists; the spec is pyinstaller/noScribe_linux.spec (same invocation as the CI workflow). Its image was tagged noscribe, which replaced the image built from docker/. Tag it noscribe-pyinstaller instead, stop on the first error and make the script executable.
chrtmnn
marked this pull request as ready for review
October 24, 2026 18:55
chrtmnn
marked this pull request as draft
October 24, 2026 18:56
chrtmnn
marked this pull request as ready for review
October 24, 2026 18:56
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script called noScribe-linux.spec, which no longer exists; the spec is pyinstaller/noScribe_linux.spec (same invocation as the CI workflow). Its image was tagged noscribe, which replaced the image built from docker/. Tag it noscribe-pyinstaller instead, stop on the first error and make the script executable.