-
Notifications
You must be signed in to change notification settings - Fork 65
Add "Validate ZTunnel values" workflow #1588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
istio-testing
merged 2 commits into
istio-ecosystem:main
from
MaxBab:add_validate_ztunnel_values_workflow
Jul 1, 2026
+488
−0
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Sail Operator is missing ZTunnel values from upstream. Please see the [job results](https://github.com/istio-ecosystem/sail-operator/actions/workflows/validate_ztunnel_values.yaml) for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| --- | ||
| name: Validate ZTunnel values | ||
|
|
||
| on: | ||
| schedule: | ||
| # Run this job every sunday at midnight | ||
| - cron: "0 0 * * 0" | ||
| workflow_dispatch: | ||
|
|
||
| permissions: {} | ||
|
|
||
| jobs: | ||
| validate-ztunnel-values: | ||
| name: Validate ZTunnel values | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| issues: write | ||
| steps: | ||
| - name: Check out the repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Run validation | ||
| run: | | ||
| make validate-ztunnel-values | ||
|
|
||
| - name: Raise an Issue to report missing ztunnel values | ||
| if: ${{ failure() }} | ||
| uses: peter-evans/create-issue-from-file@v5 | ||
| with: | ||
| title: Missing values detected by validation | ||
| content-filepath: .github/ISSUE_TEMPLATE/validate-ztunnel-values.md | ||
| labels: automated, missing ztunnel values | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # ZTunnel validation configuration | ||
| # Fields listed here will NOT be reported as missing even if they exist in upstream | ||
| # but are not implemented in the Sail Operator ZTunnelConfig | ||
| # | ||
| # Use "section.field" syntax for nested section fields (e.g., "global.networkPolicy") | ||
|
|
||
| ignore_missing_fields: | ||
| # we currently don't have a MeshConfig field in the API and if we can avoid it, we might want to keep it that way | ||
| - "meshConfig" | ||
| # FIXME: add this field | ||
| - "resourceScope" | ||
| # FIXME: add this field | ||
| - "global.networkPolicy" |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.