Add "Validate ZTunnel values" workflow#1588
Open
MaxBab wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1588 +/- ##
=======================================
Coverage 76.51% 76.51%
=======================================
Files 58 58
Lines 3181 3181
=======================================
Hits 2434 2434
Misses 609 609
Partials 138 138
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MaxBab
force-pushed
the
add_validate_ztunnel_values_workflow
branch
2 times, most recently
from
9155639 to
255d307
Compare
nrfox
reviewed
Feb 11, 2026
nrfox
reviewed
Feb 11, 2026
1 task
dgn
reviewed
Apr 10, 2026
MaxBab
force-pushed
the
add_validate_ztunnel_values_workflow
branch
from
255d307 to
578f70d
Compare
Collaborator
Author
|
/test e2e-kind-multicluster |
Collaborator
Author
|
Hi @nrfox Could you take a look, please? |
Collaborator
Author
|
/test e2e-kind-multicluster |
Collaborator
Author
|
Hi @nrfox Appreciate you review. |
Collaborator
|
Hi @MaxBab I tested your branch locally and fixed some issues I found. If you're okay with my changes I'll approve and we can get it this merged |
dgn
force-pushed
the
add_validate_ztunnel_values_workflow
branch
from
f6b1094 to
07eab2f
Compare
Ztunnel values under Sail Operator needs to be updated manually for each new created helm value. Create a github action workflow, that will validate existing Sail Operator ZTunnel config exposed values and compare them to upstream Istio helm values. Once a difference found, a missing value will be shows and an Issue will be created in order to add this value to the Sail Operator. Signed-off-by: Maxim Babushkin <mbabushk@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
dgn
force-pushed
the
add_validate_ztunnel_values_workflow
branch
from
07eab2f to
722ffd0
Compare
This adds nested field detection and it looks for missing fields in both the ZTunnelConfig and ZTunnelGlobalConfig structs as they're flattened in helm anyway - so if the field is available in any one of them, that instance can be used. I'm also adding ignores for fields that are currently missing. We need to add those missing fields and remove the ignores in subsequent PRs. Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
dgn
force-pushed
the
add_validate_ztunnel_values_workflow
branch
from
722ffd0 to
d65d2e3
Compare
Collaborator
|
@MaxBab: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Ztunnel values under Sail Operator needs to be updated manually for each new created helm value.
Create a github action workflow, that will validate existing Sail Operator ZTunnel config exposed values and compare them to upstream Istio helm values.
Once a difference found, a missing value will be shows and an Issue will be created in order to add this value to the Sail Operator.
Which issue(s) this PR fixes:
Fixes #763
Related Issue/PR #
Additional information: