Skip to content

Update dexmimicgen GR1 success rate threshold - #70

Open
peterd-NV wants to merge 1 commit into
mainfrom
peterd/update_dmg_gr1_success_rate
Open

Update dexmimicgen GR1 success rate threshold#70
peterd-NV wants to merge 1 commit into
mainfrom
peterd/update_dmg_gr1_success_rate

Conversation

@peterd-NV

@peterd-NV peterd-NV commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

Update success rate threshold to incorporate 5% buffer for variation (expected SR = 70%).

Summary by CodeRabbit

  • Tests
    • Lowered the minimum acceptable data-generation success-rate threshold from 70% to 65%.

@peterd-NV
peterd-NV requested a review from njawale42 as a code owner August 22, 2026 00:27
@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 42fc067f-8b72-4358-87f6-05a4ba24fc39

📥 Commits

Reviewing files that changed from the base of the PR and between 60f23d9 and 5b12422.

📒 Files selected for processing (1)
  • isaac_autodata_tests/datagen_perf/test_dexmimicgen_gr1_data_generation_success_rate.py

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The GR1 data-generation success-rate test lowers its minimum acceptable threshold from 0.70 to 0.65.

Changes

Data-generation success-rate validation

Layer / File(s) Summary
Update success-rate threshold
isaac_autodata_tests/datagen_perf/test_dexmimicgen_gr1_data_generation_success_rate.py
SUCCESS_RATE_THRESHOLD changes from 0.70 to 0.65.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 5b124

This PR only adjusts the GR1 success-rate test threshold to account for expected variation; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: njawale42

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes a summary but omits the required Detailed description section and exceeds the 50-character summary limit. Add the Detailed description section with the reason, change, and impact, and shorten the Summary to 50 characters or fewer.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the updated dexmimicgen GR1 success-rate threshold.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch peterd/update_dmg_gr1_success_rate

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant