-
Notifications
You must be signed in to change notification settings - Fork 0
Add SoftMimicGen for deformable objects #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
peterd-NV
wants to merge
24
commits into
main
Choose a base branch
from
peterd/smg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
edd5122
test franka rope env
peterd-NV dd22334
data gen test
peterd-NV 4dcf01d
update deps
peterd-NV 293ae4a
add frnaka rope arena env
peterd-NV 8743931
Merge branch 'main' of github.com:isaac-sim/Isaac-AutoData into peter…
peterd-NV c163877
Merge branch 'main' of github.com:isaac-sim/Isaac-AutoData into peter…
peterd-NV e44be11
add native tps util
peterd-NV 1de41d8
Merge branch 'main' of github.com:isaac-sim/Isaac-AutoData into peter…
peterd-NV b5f0d68
fix scene state for nodal
peterd-NV 8875aa1
test
peterd-NV bacca8a
Merge branch 'main' of github.com:isaac-sim/Isaac-AutoData into peter…
peterd-NV 320de1e
Merge branch 'main' of github.com:isaac-sim/Isaac-AutoData into peter…
peterd-NV af3ef6d
clean up env registration
peterd-NV f7d4846
Merge branch 'main' of github.com:isaac-sim/Isaac-AutoData into peter…
peterd-NV 5be8589
remove isaaclab franke rope rnv
peterd-NV 700e985
cleanup and headers
peterd-NV 9257252
clean up registration
peterd-NV e322aee
cleanup
peterd-NV 8c5afdc
remove script
peterd-NV 54bd3ab
add e2e test
peterd-NV 4330ca6
exclude inf cost from tps option
peterd-NV ef2e72b
Merge branch 'main' of github.com:isaac-sim/Isaac-AutoData into peter…
peterd-NV bc6e94d
Merge remote-tracking branch 'origin/main' into peterd/smg
peterd-NV 23eab87
Merge branch 'main' of github.com:isaac-sim/AutoData into peterd/smg
peterd-NV File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
Do not call a private
DataGeneratormethod from the algorithm hook.The base hook calls
data_generator._apply_subtask_transform. This makes a private method part of the algorithm plug-in contract. Every third-party or future algorithm that overridestransform_source_eef_posesand needs rigid behavior must also depend on that private name. Promote it to a public method onDataGenerator(for exampleapply_subtask_transform) and call the public name here.🤖 Prompt for AI Agents