CI: NGC login for isaac-sim 6.0.1 base pull - #53
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe CI and nightly E2E workflows now validate ChangesNGC E2E authentication
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
peterd-NV
approved these changes
Aug 4, 2026
peterd-NV
added a commit
that referenced
this pull request
Aug 5, 2026
* Log in to NGC before GPU Docker builds that pull isaac-sim. (#53) (cherry picked from commit 406e970) * Add items for OSRB (#52) * add security.md * add contributing and update license to license.md * fix ngc login * remove ngc login step from ci yaml * add ngc login step, ignore any potentailly stale credentials on runner * fix ci yaml syntax * revert login change * update contributors.md * fix license.md year (cherry picked from commit 056ea61) --------- Co-authored-by: hguillen <hguillen@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker login nvcr.iowithNGC_API_KEYbefore./scripts/ci/run_tests.sh.failed to fetch oauth token: denied: Access Deniedwhen buildingFROM nvcr.io/nvidia/isaac-sim:6.0.1(anonymous pull worked for6.0.0-dev2, not this tag).Test plan
NGC_API_KEYis set onisaac-sim/Isaac-AutoDataFROM nvcr.io/nvidia/isaac-sim:6.0.1Summary by CodeRabbit