Skip to content

CI: NGC login for isaac-sim 6.0.1 base pull - #53

Merged
peterd-NV merged 1 commit into
mainfrom
hguillen/ngc-ci-login
Aug 5, 2026
Merged

CI: NGC login for isaac-sim 6.0.1 base pull#53
peterd-NV merged 1 commit into
mainfrom
hguillen/ngc-ci-login

Conversation

@hguillen

@hguillen hguillen commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Premerge and nightly GPU jobs now docker login nvcr.io with NGC_API_KEY before ./scripts/ci/run_tests.sh.
  • Fixes failed to fetch oauth token: denied: Access Denied when building FROM nvcr.io/nvidia/isaac-sim:6.0.1 (anonymous pull worked for 6.0.0-dev2, not this tag).

Test plan

  • Confirm repo secret NGC_API_KEY is set on isaac-sim/Isaac-AutoData
  • Re-run the failing premerge E2E job (or open/update this PR) and verify NGC login succeeds and the image build progresses past FROM nvcr.io/nvidia/isaac-sim:6.0.1
  • Spot-check nightly workflow YAML still has the same login step before the full suite

Summary by CodeRabbit

  • Chores
    • Updated automated end-to-end testing workflows to authenticate securely with the container registry.
    • Added validation to stop test runs when required authentication credentials are unavailable.
    • Enabled nightly tests to pull the required simulation environment successfully.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: b4b9e836-8656-412d-96bf-27c7ce9e29c3

📥 Commits

Reviewing files that changed from the base of the PR and between c704f8a and a89727e.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • .github/workflows/nightly.yml

📝 Walkthrough

Walkthrough

The CI and nightly E2E workflows now validate NGC_API_KEY and authenticate to nvcr.io before pulling Isaac Sim images.

Changes

NGC E2E authentication

Layer / File(s) Summary
Authenticate E2E image pulls
.github/workflows/ci.yml, .github/workflows/nightly.yml
Both workflows check for an empty NGC_API_KEY, fail explicitly when it is missing, and log in to nvcr.io with the literal $oauthtoken username before E2E execution.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: njawale42

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the NGC login added for the Isaac Sim 6.0.1 base image pull.
Description check ✅ Passed The description explains the change, reason, and validation steps, but it omits the required Detailed description heading and an explicit impact statement.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hguillen/ngc-ci-login

Comment @coderabbitai help to get the list of available commands.

@peterd-NV
peterd-NV merged commit 406e970 into main Aug 5, 2026
3 checks passed
peterd-NV added a commit that referenced this pull request Aug 5, 2026
* Log in to NGC before GPU Docker builds that pull isaac-sim. (#53)

(cherry picked from commit 406e970)

* Add items for OSRB (#52)

* add security.md

* add contributing and update license to license.md

* fix ngc login

* remove ngc login step from ci yaml

* add ngc login step, ignore any potentailly stale credentials on runner

* fix ci yaml syntax

* revert login change

* update contributors.md

* fix license.md year

(cherry picked from commit 056ea61)

---------

Co-authored-by: hguillen <hguillen@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants