Skip to content

feat: use adwBanner to show enable AMD OC message #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilya-zlobintsev merged 3 commits into from
Apr 19, 2026
Merged

feat: use adwBanner to show enable AMD OC message #965

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2767b06
feat: use adwBanner to show enable AMD OC message
makarov-roman Apr 18, 2026
003363a
add hyperlink and remove mock
makarov-roman Apr 18, 2026
2a0cc50
chore: change wording slightly
ilya-zlobintsev Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lact-gui/i18n/en/lact_gui.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,7 @@ automatic-mode-threshold-tooltip = Switch fan control to auto mode when the temp
This option allows to work around this limitation by only using the custom curve when above a specific temperature, with the card's builtin auto mode that supports zero RPM being used below it.

amd-oc = AMD Overclocking
amd-oc-disabled =
AMD Overclocking support is not enabled!
You can still change basic settings, but the more advanced clocks and voltage control will not be available.
amd-oc-disabled = AMD Overclocking is not enabled! Some functionality unavailable
Copy link
Copy Markdown
Owner

@ilya-zlobintsev ilya-zlobintsev Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads a bit too broad, maybe there can be a hyperlink to the wiki page?

Copy link
Copy Markdown
Contributor Author

@makarov-roman makarov-roman Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image good idea

amd-oc-status = AMD Overclocking is currently: <b>{$status ->
[true] Enabled
[false] Disabled
Expand Down
14 changes: 12 additions & 2 deletions lact-gui/src/app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,16 @@ impl AsyncComponent for AppModel {
}
},

add_top_bar = &adw::Banner {
#[watch]
set_revealed: true,
// set_revealed: model.system_info.amdgpu_overdrive_enabled == Some(false),
Comment thread
makarov-roman marked this conversation as resolved.
Outdated
set_title: &fl!(I18N, "amd-oc-disabled"),
set_button_label: Some(&fl!(I18N, "enable-amd-oc")),

connect_button_clicked => AppMsg::ShowOverdriveDialog,
},

#[wrap(Some)]
set_content = &adw::Clamp {
set_maximum_size: CONTENT_MAXIMUM_WIDTH,
Expand Down Expand Up @@ -519,9 +529,9 @@ impl AsyncComponent for AppModel {
let info_page = InformationPage::detach_default();

let oc_page = OcPage::builder()
.launch((system_info.clone(), settings_changed.clone()))
.launch(settings_changed.clone())
.forward(sender.input_sender(), |msg| msg);
let thermals_page = ThermalsPage::builder().launch(system_info.clone()).detach();
let thermals_page = ThermalsPage::builder().launch(()).detach();

let software_page = SoftwarePage::builder()
.launch((system_info.clone(), daemon_client.embedded))
Expand Down
46 changes: 5 additions & 41 deletions lact-gui/src/app/pages/oc_page.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,23 +8,16 @@ mod vf_curve;
use super::PageUpdate;
use crate::app::pages::oc_page::gpu_stats_section::GpuStatsSectionMsg;
use crate::app::pages::oc_page::vf_curve::{VfCurveEditor, VfCurveEditorMsg};
use crate::{
I18N,
app::{ext::RelmDefaultLauchable, msg::AppMsg},
};
use crate::app::{ext::RelmDefaultLauchable, msg::AppMsg};
use amdgpu_sysfs::gpu_handle::{
PerformanceLevel, PowerLevelKind, power_profile_mode::PowerProfileModesTable,
};
use clocks_frame::{ClocksFrame, ClocksFrameMsg};
use gpu_stats_section::GpuStatsSection;
use gtk::{
pango,
prelude::{BoxExt, ButtonExt, FrameExt, OrientableExt, WidgetExt},
};
use i18n_embed_fl::fl;
use gtk::prelude::{BoxExt, OrientableExt, WidgetExt};
use indexmap::IndexMap;
use lact_schema::config;
use lact_schema::{ClocksTable, DeviceInfo, PowerStates, SystemInfo};
use lact_schema::{ClocksTable, DeviceInfo, PowerStates};
use performance_frame::{PerformanceFrame, PerformanceFrameMsg};
use power_cap_section::{PowerCapMsg, PowerCapSection};
use power_states::power_states_frame::{PowerStatesFrame, PowerStatesFrameMsg};
Expand All @@ -35,7 +28,6 @@ use tracing::debug;

pub struct OcPage {
stats_section: relm4::Controller<GpuStatsSection>,
system_info: SystemInfo,
device_info: Option<Arc<DeviceInfo>>,

performance_frame: relm4::Controller<PerformanceFrame>,
Expand Down Expand Up @@ -64,7 +56,7 @@ pub enum OcPageMsg {

#[relm4::component(pub)]
impl relm4::Component for OcPage {
type Init = (SystemInfo, BoolBinding);
type Init = BoolBinding;
type Input = OcPageMsg;
type Output = AppMsg;
type CommandOutput = ();
Expand All @@ -77,33 +69,6 @@ impl relm4::Component for OcPage {
set_margin_top: 15,
set_margin_bottom: 60,

gtk::Frame {
#[watch]
set_visible: model.system_info.amdgpu_overdrive_enabled == Some(false) && model.device_info.as_ref().is_some_and(|info| info.driver == "amdgpu"),
set_label_align: 0.3,

gtk::Box {
set_orientation: gtk::Orientation::Vertical,
set_spacing: 2,
set_margin_all: 10,

gtk::Label {
set_markup: &fl!(I18N, "amd-oc-disabled"),
set_wrap: true,
set_wrap_mode: pango::WrapMode::Word,
},

gtk::Button {
set_label: &fl!(I18N, "enable-amd-oc"),
set_halign: gtk::Align::End,

connect_clicked[sender] => move |_| {
sender.output(AppMsg::ShowOverdriveDialog).expect("Channel closed");
}
},
},
},

model.stats_section.widget(),
model.power_cap_section.widget(),
model.performance_frame.widget(),
Expand All @@ -113,7 +78,7 @@ impl relm4::Component for OcPage {
}

fn init(
(system_info, settings_changed): Self::Init,
settings_changed: Self::Init,
root: Self::Root,
sender: ComponentSender<Self>,
) -> ComponentParts<Self> {
Expand All @@ -129,7 +94,6 @@ impl relm4::Component for OcPage {
let model = Self {
stats_section,
device_info: None,
system_info,
performance_frame,
power_cap_section,
power_states_frame,
Expand Down
19 changes: 3 additions & 16 deletions lact-gui/src/app/pages/thermals_page.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ use gtk::{
};
use i18n_embed_fl::fl;
use lact_schema::{
DeviceFlag, FanControlMode, SystemInfo,
DeviceFlag, FanControlMode,
config::{FanControlSettings, FanCurve, GpuConfig},
default_fan_curve,
};
Expand All @@ -41,7 +41,6 @@ const STATIC_PAGE: &str = "static";

pub struct ThermalsPage {
fan_curve_frame: relm4::Controller<FanCurveFrame>,
system_info: SystemInfo,
selected_mode: StringBinding,

custom_control_supported: bool,
Expand Down Expand Up @@ -91,7 +90,7 @@ pub enum ThermalsPageMsg {

#[relm4::component(pub)]
impl relm4::Component for ThermalsPage {
type Init = SystemInfo;
type Init = ();
type Input = ThermalsPageMsg;
type Output = ();
type CommandOutput = ();
Expand All @@ -103,17 +102,6 @@ impl relm4::Component for ThermalsPage {
set_margin_vertical: 15,
set_margin_horizontal: 30,

gtk::Frame {
#[watch]
set_visible: model.system_info.amdgpu_overdrive_enabled == Some(false)
&& model.has_pmfw
&& model.fan_speed.is_some(),

gtk::Label {
set_label: &fl!(I18N, "oc-missing-fan-control-warning"),
},
},

PageSection::new(&fl!(I18N, "monitoring-section")) {
append_child = &gtk::FlowBox {
set_orientation: gtk::Orientation::Horizontal,
Expand Down Expand Up @@ -351,7 +339,7 @@ impl relm4::Component for ThermalsPage {
}

fn init(
system_info: Self::Init,
_init: Self::Init,
root: Self::Root,
_sender: ComponentSender<Self>,
) -> ComponentParts<Self> {
Expand Down Expand Up @@ -387,7 +375,6 @@ impl relm4::Component for ThermalsPage {
fan_curve_frame,
throttling: String::new(),
temperatures: None,
system_info,
pmfw_options,
pmfw_change_signals,
custom_control_supported: false,
Expand Down
Loading