feat: use adwBanner to show enable AMD OC message#965
Merged
ilya-zlobintsev merged 3 commits intoilya-zlobintsev:masterfrom Apr 19, 2026
Merged
Conversation
ilya-zlobintsev
requested changes
Apr 18, 2026
| amd-oc-disabled = | ||
| AMD Overclocking support is not enabled! | ||
| You can still change basic settings, but the more advanced clocks and voltage control will not be available. | ||
| amd-oc-disabled = AMD Overclocking is not enabled! Some functionality unavailable |
Owner
There was a problem hiding this comment.
This reads a bit too broad, maybe there can be a hyperlink to the wiki page?
Owner
|
I had to re-add the driver check in 2452a9e, otherwise it would show the banner unnecessarily on a multi-GPU system: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on one of the screenshots you shared I noticed that the current style for Enable AMD OC doesn't fit.
I tried to use PageSection first, but it didn't look right. Also We want this warning to be shown all the time, because it's relevant to multiple pages.