Skip to content

Restore state_class to more ecowitt rain sensors #158528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
epenet wants to merge 2 commits into from
Closed

Restore state_class to more ecowitt rain sensors #158528

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c755f77
Add state_class to more ecowitt rain sensors
epenet Dec 10, 2025
f10de0f
Add state_class to more ecowitt rain sensors
epenet Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 34 additions & 5 deletions homeassistant/components/ecowitt/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,39 @@
),
}

# Rain count sensors can be rolling windows or reset periodically
# Only those that reset should get marked as TOTAL_INCREASING
_TOTAL_INCREASING_RAIN_COUNT_SENSORS: Final = {
# Lifetime total rain sensors
"totalrainin",
"totalrainmm",
# Yearly, resets 1st day of the year
"yearlyrainin",
"yearlyrainmm",
"yrain_piezo",
"yrain_piezomm",
# Monthly, resets 1st day of the month
"monthlyrainin",
"monthlyrainmm",
"mrain_piezo",
"mrain_piezomm",
# Weekly, resets 1st day of the week
"weeklyrainin",
"weeklyrainmm",
"wrain_piezo",
"wrain_piezomm",
# Daily, resets at midnight
"dailyrainin",
"dailyrainmm",
"drain_piezo",
"drain_piezomm",
# Event, resets after 24hrs without rain
"eventrainin",
"eventrainmm",
"erain_piezo",
"erain_piezomm",
}


async def async_setup_entry(
hass: HomeAssistant,
Expand Down Expand Up @@ -285,11 +318,7 @@ def _new_sensor(sensor: EcoWittSensor) -> None:
name=sensor.name,
)

# Only total rain needs state class for long-term statistics
if sensor.key in (
"totalrainin",
"totalrainmm",
):
if sensor.key in _TOTAL_INCREASING_RAIN_COUNT_SENSORS:
description = dataclasses.replace(
description,
state_class=SensorStateClass.TOTAL_INCREASING,
Expand Down
Loading