Skip to content

Restore state_class to more ecowitt rain sensors#158528

Closed
epenet wants to merge 2 commits intodevfrom
epenet-20251210-1125
Closed

Restore state_class to more ecowitt rain sensors#158528
epenet wants to merge 2 commits intodevfrom
epenet-20251210-1125

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Dec 10, 2025

Proposed change

Restore state-class for sensors whose state class was accidentally removed in #155321 / #155812

Alternative to #158204

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @pvizeli, mind taking a look at this pull request as it has been labeled with an integration (ecowitt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ecowitt can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ecowitt Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@epenet epenet added this to the 2025.12.3 milestone Dec 10, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores the state_class attribute for Ecowitt rain sensors that were accidentally removed in previous changes (#155321 / #155812). The fix introduces a new constant _TOTAL_INCREASING_RAIN_COUNT_SENSORS containing all rain sensors that reset periodically, enabling proper long-term statistics tracking for these sensors.

Key changes:

  • Added a new constant set containing 20 rain sensor keys (totalrain, yearlyrain, monthlyrain, weeklyrain, dailyrain, and eventrain in both imperial and metric units, including piezo variants)
  • Replaced hardcoded sensor key checks with a lookup in the new constant set
  • All identified sensors reset at defined intervals (lifetime, yearly, monthly, weekly, daily) or conditions (event sensors reset after 24 hours without rain)

@epenet epenet changed the title Add state_class to more ecowitt rain sensors Restore state_class to more ecowitt rain sensors Dec 10, 2025
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is competing with another one; while the implementation difference is a detail of deny/allow listing, the real issue stems from it not being explicit to begin with.

See also: #158204 (comment)

../Frenck

                       

Blogging my personal ramblings at frenck.dev

@home-assistant home-assistant Bot marked this pull request as draft December 10, 2025 13:59
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Dec 10, 2025

Happy to close - I only opened it due to refusal of taking into account feedback on the other PR.

@epenet epenet closed this Dec 10, 2025
@epenet epenet deleted the epenet-20251210-1125 branch December 10, 2025 14:02
@frenck
Copy link
Copy Markdown
Member

frenck commented Dec 10, 2025

Happy to close - I only opened it due to refusal of taking into account feedback on the other PR.

I get it ❤️ , but let's step back and make it solid 👍

../Frenck

                       

Blogging my personal ramblings at frenck.dev

@github-actions github-actions Bot locked and limited conversation to collaborators Dec 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants