Fix GraspObjectNode initializaton order for ROS 2 humble#235
Open
hello-jkoubi wants to merge 1 commit into
Open
Fix GraspObjectNode initializaton order for ROS 2 humble#235hello-jkoubi wants to merge 1 commit into
hello-jkoubi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix an initialization-order issue in
grasp_objecton ROS 2 Humble.MoveBasewas being constructed before the underlying ROS node was fully initialized. Since MoveBase declares ROS parameters during initialization,ros2 run stretch_demos grasp_objectresulted in:This change delays
MoveBaseinitialization until afterHelloNode.main()completes, ensuring the node is fully initialized before parameters are declared.Testing Notes
grasp_object.pydepends onstretch_funmapPython packages through the virtual environment workflow.To test this PR, first apply the companion venv-wrapper PR and re-wrap the
stretch_demosexecutables:Then verify that the node starts successfully:
Before this fix, the command failed during startup with:
After this change,
grasp_objectshould initialize successfully.