Improve eye LED animation utility#35
Open
hello-shivam-bhardwaj wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the existing
stretch_eye_animationsutility so it can be used both interactively and from command-line scripts.The utility now supports:
--listto print available eye animation names and indexes without touching hardware.--list-colorsto print named RGB colors.--animationto set both eyes at once.--leftand--rightto control each eye separately.--color,--rgb, and--intensityfor color/intensity control.--directand--usbfor direct serial access, matching other power-periph utilities.Why
During PIMU LED timing validation, we needed a repeatable way to command eye LED patterns without adding temporary firmware hooks. The previous utility required repeated interactive prompts, which made hardware testing slower and harder to document.
This keeps the control surface in Stretch Body, where operators and test scripts already expect robot utilities to live.
Examples
List animations:
Set both eyes to idle glow at Stretch default color:
Set different animations per eye using direct serial:
Use explicit RGB values:
Validation
Local:
python3 -m py_compile stretch4_body/tools/stretch_eye_animations.pyBench NUC on
stretch-se4-4032/10.1.10.32:/tmp.--listsuccessfully./dev/hello-power-periphsuccessfully.IDLE_GLOWat default Stretch color/intensity after the test.Review Notes
This PR does not change firmware behavior or the PowerPeriph API. It only makes the existing eye animation command path easier to use from scripts and bench tests.