Add power periph event diagnostics trigger API#33
Draft
hello-shivam-bhardwaj wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the small
stretch4_bodycompanion PR for the firmware diagnostics gate in hello-robot/stretch_firmware_ii#32.It does not change normal robot behavior by itself. It only exposes the host-side controls needed to explicitly enable or disable the firmware diagnostic window when debugging.
What Changed
PowerPeriphmethods to enable and disable diagnostics.RobotClientqueue methods for the same operations through the body server path.Risk Controls
Validation
Local:
python3 test/test_power_periph_event_diagnostics.pyBench / NUC:
hello-robot-stretch4-bodyon the NUC.stretch_body_iiis no longer imported by active console scripts./dev/hello-power-periph.Suggested Review Focus
This PR is mainly API plumbing. The useful review questions are whether the trigger names, direct API, body-server API, and docs are clear enough for debug tooling and reviewers.