Skip to content

use SecureRandom for external compile worker auth cookie #10366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Samin061 wants to merge 1 commit into from
Closed

use SecureRandom for external compile worker auth cookie #10366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dev/core/src/com/google/gwt/dev/ExternalPermutationWorkerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@
import java.net.ServerSocket;
import java.net.Socket;
import java.net.SocketTimeoutException;
import java.security.SecureRandom;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.HashSet;
import java.util.Iterator;
import java.util.List;
import java.util.Random;
import java.util.Set;

/**
Expand Down Expand Up @@ -220,7 +220,7 @@ public void shutdown() {
/**
* Random number generator used for keys to worker threads.
*/
private static Random random = new Random();
private static final SecureRandom random = new SecureRandom();

/**
* Launches an external worker and returns the cookie that worker should
Expand Down