use SecureRandom for external compile worker auth cookie#10366
Closed
Samin061 wants to merge 1 commit into
Closed
Conversation
Member
|
#10257 is a full patch for the linked issue - would you consider reviewing that instead? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The one-time cookie that authenticates a CompilePermsServer worker connecting back to the compiler's ephemeral ServerSocket is generated with java.util.Random, whose 48-bit seed makes the value guessable, so someone able to reach the port during a compile could predict the cookie and feed crafted serialized data to the worker socket's ObjectInputStream. Generate it with SecureRandom instead.
Partial #10256