-
Notifications
You must be signed in to change notification settings - Fork 2
Expand catalog of units and registers, fix some and use decimals #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c1a72ea
constants: reword code comment on REGISTERS
gertvdijk 2d82017
constants: use decimal IDs for registers and units instead of hex
jktjkt 6706e0b
constants: fix unit ID 38 display name (°K → K)
jktjkt ff58727
constants: fix unit ID 21 display name (kW → W)
jktjkt f5b58a2
constants: fix unit ID 25 display name (kvar → var)
jktjkt 61ab795
constants: add unit IDs 65, 66 and 85-90
jktjkt a0bd37f
constants: add V1 suffix to display names of register IDs 68 and 74
jktjkt 7c94725
constants: add E8/E9 suffixes to display names of register IDs 97 and…
jktjkt 6af91e5
constants: add 90 new register IDs for Multical 603 and Multical 303
jktjkt 9690242
constants: add 18 new registers used in electricity meters
gertvdijk 6e77910
docs: add changelog entries for recent register and unit catalog updates
gertvdijk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can also add:
65: "imp/L",impulses per liter66: "L/imp",liters per impulseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll adopt it lowercase as other liters are denoted with lowercase-
l, is that OK?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed