[2.x] chore(audit): move third-party integrations out to their own extensions#4807
Merged
Conversation
The bundled FoF integrations (ban-ips, impersonate, merge-discussions, split, user-bio, username-request) now declare their own audit integration via the public Flarum\Audit\Extend\Audit extender, gated behind a Conditional on flarum-audit — the same pattern flarum/suspend uses. Removes their blocks, locale strings, tests and the username-request integration class from flarum/audit. With no third-party integrations left, extend.thirdparty.php is deleted and extend.php returns its extenders directly.
imorland
changed the title
This was referenced Jul 8, 2026
imorland
added a commit
that referenced
this pull request
Jul 8, 2026
imorland
added a commit
that referenced
this pull request
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #4806 (which removed the clarkwinkelmann-author-change integration). This moves the remaining bundled third-party audit integrations out of
flarum/auditand into the extensions that own the events, using the publicFlarum\Audit\Extend\Auditextender behind aConditionalonflarum-audit— the same patternflarum/suspendalready uses.Moved to their own extensions (companion PRs)
Each FoF extension now ships its own integration, locale strings (under the
flarum-audit.lib.browser.*namespace) andAuditTest:FoFUsernameRequestIntegrationclass moves into the extension too)Changes here
extend.thirdparty.php(now empty) and return the extenders directly fromextend.php(no morearray_merge).tests/integration/thirdparty/*tests, andsrc/Integration/FoFUsernameRequestIntegration.php.thirdpartyexclude fromphpunit.integration.xmland thefof username requestcase fromIntegrationActionRegistrationTest.Coordination
The integration is duplicated (audit + extension) until the FoF releases land, and there's a brief coverage gap if this merges before them — so these should be released together with the companion FoF PRs above.