-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(dmg): migrate to APFS as default filesystem for DMG builds #9616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
4ba300e
3290188
897ba34
5dc0894
d111bd0
2df990b
ed7bbd8
788ad20
af67044
eed4f83
c252a2c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "dmg-builder": patch | ||
| --- | ||
|
|
||
| fix(dmg): use APFS as default filesystem for DMG builds due to incompatibilities on latest MacOS w/ HFS+ |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -127,9 +127,10 @@ describe.heavy.ifMac("dmg", { sequential: true }, () => { | |
| const totalBytes = stats.bsize * stats.blocks | ||
|
|
||
| // 500m should give ~524,288,000 bytes (500 * 1024 * 1024) | ||
| // Allow margin for filesystem overhead (450MB to 600MB) | ||
| // Allow margin for filesystem overhead. APFS can report larger sizes than HFS+ due to | ||
| // different block sizing and allocation, so use a wide range (450MB–1GB). | ||
| const minBytes = 450 * 1024 * 1024 | ||
| const maxBytes = 600 * 1024 * 1024 | ||
| const maxBytes = 1024 * 1024 * 1024 | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a huuuge new range for just changing filesystem. Is the dmg size being minimized?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could be a good one. Let's try
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ur right, lemme see what I can do. |
||
|
|
||
| expect(totalBytes).toBeGreaterThan(minBytes) | ||
| expect(totalBytes).toBeLessThan(maxBytes) | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.