fix(dmg): migrate to APFS as default filesystem for DMG builds#9616
fix(dmg): migrate to APFS as default filesystem for DMG builds#9616RobbieMinderhoud wants to merge 11 commits intoelectron-userland:masterfrom
Conversation
🦋 Changeset detectedLatest commit: c252a2c The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mmaietta
changed the title
mmaietta
changed the title
mmaietta
left a comment
mmaietta
left a comment
There was a problem hiding this comment.
Please resolve tsc errors when you have a chance and we can quickly move forward with this PR. Thanks!
…houd/electron-builder into fix/apfs-default-filesystem - #
|
@mmaietta Sorry, it's been a while. Was working with a local patch. This is fixed now. Let's hope the tests pass. I'll check tomorrow. |
|
Currently making a fix for the last test |
|
@mmaietta Would you happen to have time to look at it again? |
|
THank you! Fixing the tests currently |
Increased test size, APFS could result in a larger build.
|
@mmaietta Increased the size of DMGTest.js, APFS can be larger. |
…ze range to 450MB–1GB - #
|
@mmaietta Increasing the size, just a little more... Let's hope this will do it. |
| // different block sizing and allocation, so use a wide range (450MB–1GB). | ||
| const minBytes = 450 * 1024 * 1024 | ||
| const maxBytes = 600 * 1024 * 1024 | ||
| const maxBytes = 1024 * 1024 * 1024 |
There was a problem hiding this comment.
This is a huuuge new range for just changing filesystem. Is the dmg size being minimized?
Maybe we can do 2 tests, one for HFS and another for APFS
There was a problem hiding this comment.
Could be a good one. Let's try
There was a problem hiding this comment.
Ur right, lemme see what I can do.
|
Hi @RobbieMinderhoud , have you had a chance to investigate on this further? |
2 participants
Fixes #9615