Repository navigation
Move stuff to config from schema - #846
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
framework-performance | 052187c | Commit Preview URL Branch Preview URL |
Nov 13 2026, 07:08 AM |
dreyfus92
left a comment
There was a problem hiding this comment.
nice, this reads a lot cleaner.
one thing, since the config now lives in the file anyway: benchmarkIdentity only checks name / bodySize / duplicationFactor, and CombinedResultSchema strips configuration on read, so if something like warmupDurationMs changes later, variance would compare against a run with different settings. could we keep configuration when reading and skip variance for a test when its config differs from the previous file? not blocking if you'd rather do it separately
also the ssr load check that the measured stages match stageConnections went away with the move, could live in the save step against measurementsConfig
|
@dreyfus92 I fixed the |
|
@dreyfus92 As for the first issue I still want to run the variance if the settings change. However it probably needs some tweaks if runs increase. I will have a think about that in its own PR |
Final changes to the schema to make things clearer:
measurements.ts-configon the end andconfigin the exported nameThis is the last PR that unblock the simplification of the components in the docs. Nothing like a spring clean
This PR looks large due to the config changes so just review: