Skip to content

Move stuff to config from schema - #846

Merged
AlexanderKaran merged 5 commits into
mainfrom
move-stuff-to-config-from-schema
Nov 13, 2026
Merged

AlexanderKaran merged 5 commits into
mainfrom
move-stuff-to-config-from-schema

Conversation

@AlexanderKaran

@AlexanderKaran AlexanderKaran commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Final changes to the schema to make things clearer:

  • Move any left over config out of the schema and into measurements.ts
  • Update the runner to user it from the the measurements config
  • Migrated every past schema so config is top level rather than split between tests
  • Renamed frameworks and measurements files to -config on the end and config in the exported name

This is the last PR that unblock the simplification of the components in the docs. Nothing like a spring clean

This PR looks large due to the config changes so just review:

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
framework-performance 052187c Commit Preview URL

Branch Preview URL
Nov 13 2026, 07:08 AM

@dreyfus92 dreyfus92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this reads a lot cleaner.

one thing, since the config now lives in the file anyway: benchmarkIdentity only checks name / bodySize / duplicationFactor, and CombinedResultSchema strips configuration on read, so if something like warmupDurationMs changes later, variance would compare against a run with different settings. could we keep configuration when reading and skip variance for a test when its config differs from the previous file? not blocking if you'd rather do it separately

also the ssr load check that the measured stages match stageConnections went away with the move, could live in the save step against measurementsConfig

@AlexanderKaran

Copy link
Copy Markdown
Collaborator Author

@dreyfus92 I fixed the stageConnections in ssrLoad

@AlexanderKaran

Copy link
Copy Markdown
Collaborator Author

@dreyfus92 As for the first issue I still want to run the variance if the settings change. However it probably needs some tweaks if runs increase. I will have a think about that in its own PR

@AlexanderKaran
AlexanderKaran merged commit a4b7fb1 into main Nov 13, 2026
97 checks passed
@AlexanderKaran
AlexanderKaran deleted the move-stuff-to-config-from-schema branch November 13, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants